bread crumb incorrect on node-type admin pages

This patch adds a new key to the array returned by hook_menu(), 'parent'. This allows “stepchildren”, i.e. menu items that belong elsewhere in the hierarchy than indicated by the path structure.

There was a name collision with a form element that was present in the array passed on to menu_link_save() from menu_edit_item_submit().

Forgot to update the tests.

It seems that the symptoms have changed a bit, since this issue was originally filed. Here they look like this:
- breadcrumb trail on admin/build/node-type/example lists “Home » Administer » Structure”
- breadcrumb trail on admin/build/node-type/example/delete only lists “Home”

It turns out that the above patch only fixes the first of these cases. That was introduced in #204415: Creating content types 'add', 'theme', 'list' (and possibly others) causes various problems when part of admin/build/types was split into admin/build/node-type.

The second case isn't caused by something else. If a page has the path abc/def/ghi, and abc/def is a MENU_CALLBACK, it is saved in menu_links as having no parent and abc/def does not appear in the breadcrumb. I don't know why this is - MENU_CALLBACK does have the MENU_VISIBLE_IN_BREADCRUMB flag. This was introduced in #137767: multiple menu support in the patch in comment #61 without any explanation. I have removed this restriction.

This revealed another problem. The "user/logout" menu item resides in the "user-menu" menu, and the "user" menu item is a MENU_CALLBACK resides in the "navigation" menu. Now that menu items are allowed to be children of MENU_CALLBACKs, this makes "user/logout" become a child of "user" and thus moves from "user-menu" to "navigation", when the reset link is presset in “Home » Administer » Structure » Menus » List links”. I made a change so that when hook_menu returns a menu_name, the menu item becomes a top-level item in the specified menu and breaks the relation to the item that would otherwise be its parent.

It sounds to me like this isn't the proper solution. The proper solution would be to change the URLs of node-type admin pages to respect the structure.

Note that the current URL structure was made intentionally in #204415: Creating content types 'add', 'theme', 'list' (and possibly others) causes various problems, when part of admin/build/types was split into admin/build/node-type.

Thanks for taking the time to report this issue.

However, marking as duplicate of #508570: Restore URL consistency for node types and menus.
You can follow up on that issue to track its status instead. If any information from this issue is missing in the other issue, please make sure you provide it over there.

This bread crumb issue wasn't fixed by #508570: Restore URL consistency for node types and menus, but the problem is being adressed in #483614: Better breadcrumbs for callbacks, dynamic paths, tabs.

Edit: Fixed wrong issue reference.