Problem/Motivation
PHPStan 2.3.6 is available, so we can probably get this in for the 12 and 11.5 RCs.
We should update that and any outstanding PHPStan packages for main, 12.0.x, 11.x, and 11.5.x to keep the versions in sync and reduce the instances of baseline conflicts on backports.
Proposed resolution
1) Bump PHPStan to version 2.3.6 and friends to latest available
composer update jangregor/phpstan-prophecy mglaman/phpstan-drupal phpstan/extension-installer phpstan/phpdoc-parser phpstan/phpstan phpstan/phpstan-deprecation-rules phpstan/phpstan-phpunit spaze/phpstan-disallowed-calls
Remaining tasks
User interface changes
Introduced terminology
API changes
Data model changes
Release notes snippet
Comments
Comment #4
mondrakeComment #5
godotislateThis lgtm. I think we'll need a separate MR for 11.x/11.5.x.
Comment #8
catchCommitted/pushed to main and 12.0.x - had to do a small composer.lock commit conflict on 12.0.x
Moving to 11.x for backport.
Comment #10
godotislateOpened https://git.drupalcode.org/project/drupal/-/merge_requests/17853 for 11.x
It was mentioned in #3621326-67: Update to PHPStan 2.2.14 that we may have dropped PHPStan 1 compatibility in 11.x accidentally, so restored it in the MR.
Comment #11
godotislateTests are green.
Comment #12
mondrakeLgtm
Comment #14
godotislateSeemed to cherry-pick fine to 11.5.x, but opened a separate MR just in case: https://git.drupalcode.org/project/drupal/-/merge_requests/17855