Problem/Motivation

The webship-js suite was written for webship-js 2.0.6. Read against webship-js 2.0.12 and the corrected practice of the book (Automated Functional Testing Recipes), it does not hold:

  • The first scenario creates the test accounts (I add testing users), and cucumber.js holds their passwords.
  • The module checks read the Extend page checkboxes by id.
  • cucumber.js is not the one npx init-webship-js writes (a feature named on the command line still runs every feature), and the suite asks for webship-js ^2.0.6 and @webship-js/drupal-core-steps ^2.1.0, with @cucumber/cucumber pinned to 10.0.1 while webship-js asks for ^12.
  • tests/README.md gives the site install with a committed password, and the READMEs name the Swagger UI library's package by its vendor.

Steps to reproduce

  1. Build a site from drupal/webships_project 12.0.x-dev in DDEV, install it with the WebAPI Starter site template.
  2. Run the suite as it is: 15 of 15 pass, and the run leaves the accounts it made on the site.

Proposed resolution

  • cucumber.js from the webship-js 2.0.12 scaffold, with the pack and the users registry: credentials from the environment, CHANGE_ME placeholders. The Playwright config of the scaffold.
  • The site build makes the accounts (CI: drush, with passwords made for the job); the suite only logs in.
  • Module and content type checks through the pack.
  • webship-js ^2.0.12, @webship-js/drupal-core-steps ^2.2.3, no cucumber-js pin.
  • tests/README.md: the full install, from a new DDEV site to a green run, and the Test users. The READMEs describe the Swagger UI library package without its vendor.

AI-Generated: Yes (tests updated with Claude Code; reviewed by Rajab Natshah.)

Remaining tasks

  • ✅ File an issue
  • ✅ Addition/Change/Update/Fix
  • ✅ Testing to ensure no regression
  • ✅ Automated unit/functional testing coverage
  • ✅ Developer Documentation support
  • ➖ User Guide Documentation support
  • ➖ UX/UI designer responsibilities
  • ➖ Accessibility and Readability
  • ❌ Reviewed by a human
  • ❌ Code review by maintainers
  • ❌ Full testing and approval
  • ❌ Credit contributors
  • ❌ Review with the product owner
  • ❌ Update Release Notes
  • ❌ Release

User interface changes

  • N/A

API changes

  • N/A

Data model changes

  • N/A

Release notes snippet

  • N/A
Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

rajab natshah created an issue. See original summary.

  • rajab natshah committed 2f18c01e on 2.0.x
    test: #3639053 Update the webship-js suite for webship-js 2.0.12, with...
rajab natshah’s picture

Issue summary: View changes
Status: Active » Needs review

Merged in !15 (no squash: 2.0.x is at 2f18c01e7f), and pushed to the GitHub mirror.

  • Pipeline #1053251 green: webship-js-test 15 scenarios (15 passed), 83 steps, on a Standard site with the recipe applied; recipe, eslint, composer-lint green.
  • On a site installed from the recipe of drupal/webships_project 12.0.x-dev (DDEV, Node.js 24): 15 of 15 twice in a row; also 15 of 15 on the same codebase installed by the Webships installer.

Needs a human review; left open for the release round (no tag, no release).