i recognized the functions template_preprocess_node/block in the file inclues/theme.inc

this is for me not the logically place, they should be in modules/node/node.module and modules/block/block.module

any oppinions about it?

CommentFileSizeAuthor
#3 move_preprocess_node_block.patch5.41 KBdawehner
#1 move_preprocess_node_block.patch8.01 KBdawehner
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Status: Active » Needs review
FileSize
move_preprocess_node_block.patch8.01 KB

here is a fast patch

perhaps a argument for doing this is also that you could include theme.inc without want to use node/block module. Only use the awesomeness of stuff like theme_item_list

Status: Needs review » Needs work

The last submitted patch failed testing.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Status: Needs work » Needs review
FileSize
move_preprocess_node_block.patch5.41 KB

rerole

it seams that preprocess_block moved to block.module

cburschka’s picture

cburschka
they
CreditAttribution: cburschka commented
Status: Needs review » Reviewed & tested by the community

Good call. If the block function has already moved, it makes sense to move the node function too...

Dries’s picture

Dries CreditAttribution: Dries commented
Status: Reviewed & tested by the community » Fixed

Committed to CVS HEAD. Thanks.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.