Problem/Motivation

The first GitLab CI pipeline on 1.0.x passed, but four jobs that are allowed to fail reported problems:

  • phpcs: one warning in gitlab_templates_version.txt, a file that the pipeline itself creates.
  • ESLint: config/install/earkiv.settings.yml is empty, which the YAML rules do not allow (yml/no-empty-document). A new installation also starts without a default archiver and storage.
  • cspell: unknown words such as Arkiv, earkiv, httrack, webimage, RRULE, DTSTART, BYDAY, BYHOUR, BYMINUTE, BYSECOND, pids and sitemapindex.
  • phpstan: 13 errors, among them ten \Drupal calls in classes (ArchiveListBuilder, HTTrackCommands, HTTrackArchiver, LocalStorage) and a missing return type on ArchiveListBuilder::getDefaultOperations(). The two plugin managers use annotation discovery, which is deprecated in Drupal 11.2; that is handled in a separate issue for Drupal 12.

Proposed resolution

  1. Exclude gitlab_templates_version.txt in phpcs.xml.dist.
  2. Give config/install/earkiv.settings.yml the default archiver and storage and their default settings, matching the configuration schema.
  3. Add .cspell-project-words.txt with the words of the module.
  4. Inject the services instead of calling \Drupal in the classes that phpstan reports, and add the missing return type.

Each step is a separate commit. phpstan may still report the annotation discovery until the Drupal 12 issue is done.

Remaining tasks

  • Implement and check the pipeline.
  • Review.

User interface changes

A new installation has the HTTrack archiver and the local storage selected by default.

API changes

None.

Data model changes

Default configuration in config/install/earkiv.settings.yml. Existing sites are not affected.

AI-Generated: Yes (Used Claude Code to read the pipeline results and draft this issue.)

Issue fork earkiv-3637005

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

thomas alsén created an issue. See original summary.

thomas alsén’s picture

Status: Active » Fixed

Merged into 1.0.x!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.