First patch fixing this: removing getActiveConnection and keeping only getConnection and making openConnection return the connection instead of magically storing it. This makes following db_select/db_insert etc etc much easier because now all pieces in getConnection is visible and there is only one connection function to read. Impact on HEAD? I suspect none at all.
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | getConnection.patch | 23.59 KB | chx |
| #3 | getConnection.patch | 21.48 KB | chx |
| #1 | getConnection.patch | 21.48 KB | chx |
| getConnection.patch | 20.26 KB | chx |
Comments
Comment #1
chx commentedNow, the more-often used $target parameter is the first one. This allows really nice parameter passing.
Comment #3
chx commentedTests now pass.
Comment #4
chx commentedTests would pass if I would upload the right patch.
Comment #5
chx commentedAnd the next issue is #363802: Document class methods with class, factory and defining interfaces
Comment #6
Crell commentedchx and I discussed this at length in IRC before he submitted it, and I'm OK with it.
chx, when this lands can you also update the docs at: http://drupal.org/node/310070
Comment #7
Crell commentedEr, yeah, changing status would be good too.
Comment #8
dries commentedThis looks like a good simplification indeed -- I remember scratching my head about this when I reviewed early version of the new database abstraction layer. Doing some review and testing now.
Comment #9
dries commentedCommitted to CVS HEAD. Thanks chx!
Comment #10
dries commentedUhm, the KLM lounge at Amsterdam/Schiphol airport does not allow me to do CVS commits ...
Comment #11
webchickKLM lounge FAIL. ;)
Committed to HEAD. Docs please. :)
Comment #12
chx commented