Problem/Motivation

The project has no .gitlab-ci.yml and no automated tests. Merge requests get no pipeline, and changes to FieldPdfReaderField can’t be checked for regressions. This is groundwork for a set of small improvements to the existing renderers.

Proposed resolution

  • Add the standard Drupal Association .gitlab-ci.yml template, unmodified.
  • Add a kernel test that covers what the existing renderers (Google Viewer, Microsoft Viewer, Direct Embed, pdf.js) currently output: the theme hook, the URL shape and the attached libraries.
  • No changes to how the module works.

Remaining tasks

  • Review
  • Confirm the pipeline passes

User interface changes

None

API changes

None

Data model changes

None

Issue fork pdf_reader-3635944

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

whthat created an issue. See original summary.

whthat opened merge request !9

whthat changed the visibility of the branch 3635944-add-gitlab-ci to hidden.

whthat’s picture

whthat commented
Status: Active » Needs review