Problem/Motivation

Node.js 20 reached end of life on 30 April 2026, and Drupal core main now requires "node": ">= 24.0" in core/package.json. Rightup has no engines block in package.json and runs Node 20 in its GitLab CI.

Node 24 is the LTS line, latest v24.22.2, and it is one of the lines the November 2026 security releases will patch. Pinning the major picks those patches up with no further change. Local systems should use Node.js 24 or 26.

Steps to reproduce

  1. On 1.0.x, open package.json: there is no engines block and no packageManager, though .yarnrc.yml and tests/README.md set the suite up for Yarn 4.
  2. Open .gitlab-ci.yml: the cspell, ESLint, Cucumber dry-run and report jobs run node:20.

Proposed resolution

  • package.json: engines "node": ">= 24.0" and "yarn": ">= 4.18.1", and packageManager yarn@4.18.1. .yarnrc.yml already follows the Varbase standard.
  • .gitlab-ci.yml: node:24 for the cspell, ESLint, Cucumber dry-run and report jobs. The functional jobs keep the Playwright image and its Node.
  • tests/README.md: Node.js 24 or 26 and Yarn 4.18.1, and node:24 for gitlab-ci-local.
  • The test scripts run node ./node_modules/@cucumber/cucumber/bin/cucumber.js, as Varbase Starter does: Yarn 4 does not link the cucumber-js bin of a dependency of @vardot/varbase-e2e, so yarn test failed with Yarn 4.18.1. CI calls ./node_modules/.bin/cucumber-js after npm install and is unchanged.
  • No lockfile is committed. .gitignore now ignores yarn.lock, package-lock.json and pnpm-lock.yaml. CI installs with npm install. The ranges are already carets.

AI-Generated: Yes

Remaining tasks

  • ✅ File an issue
  • ✅ Addition/Change/Update/Fix
  • ✅ Testing to ensure no regression
  • ➖ Automated unit testing coverage
  • ➖ Automated functional testing coverage
  • ➖ UX/UI designer responsibilities
  • ➖ Readability
  • ➖ Accessibility
  • ➖ Performance
  • ➖ Security
  • ➖ Developer Documentation
  • ➖ User Guide Documentation
  • ❌ Reviewed by human
  • ❌ Code review by maintainers
  • ❌ Full testing and approval
  • ❌ Credit contributors
  • ❌ Review with the product owner
  • ❌ Release notes snippet
  • ❌ Release

User interface changes

  • N/A

API changes

  • N/A

Data model changes

  • N/A

Release notes snippet

  • Node.js 24 or newer is now required, in the engines and CI. Yarn 4.18.1 is the package manager.

Issue fork rightup-3635695

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

rajab natshah created an issue. See original summary.

rajab natshah’s picture

Issue summary: View changes

rajab natshah’s picture

Issue summary: View changes
Status: Active » Needs review