Problem/Motivation

The Standard recipe grants the Content editor role administer url aliases and create url aliases, but it does not install the Path module. Core drops both permissions and only logs a message. #3587118 removed the recipes that used to install Path. It also added user.role.content_editor to the differences StandardRecipeTest allows, so the test did not catch it.

Steps to reproduce

Apply core/recipes/standard. The Content editor role has no URL alias permissions.

Proposed resolution

Add path to the recipe's install list, as the Standard profile does. Remove user.role.content_editor from the differences StandardRecipeTest allows.

Remaining tasks

Review.

User interface changes

None.

API changes

None.

Data model changes

None.

Issue fork drupal-3635277

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

alaa abbad created an issue. See original summary.

alaa abbad’s picture

Status: Active » Needs review

MR !17689 adds path to the Standard recipe and removes user.role.content_editor from the expected differences in StandardRecipeTest. Without the fix, the test fails on that role.

smustgrave’s picture

smustgrave’s picture

Status: Needs review » Needs work

Not sure how the test change is related to the path module failing.

Could we also cleanup the summary of some of the AI verbose please for the reviewers and committers

alaa abbad’s picture

Issue summary: View changes
alaa abbad’s picture

Status: Needs work » Needs review

The test change is what catches the bug. StandardRecipeTest installs the site with the Standard profile and exports its config. Then it rebuilds the site with the Standard recipe and compares the two. #3587118 added user.role.content_editor to the config that is allowed to differ, so the test passed even though the recipe's role had lost the two URL alias permissions. With that line removed, the test fails without the fix. With path installed, the role is the same both ways and the test passes. I've shortened the summary.

smustgrave’s picture

May I ask did AI trim the summary? Only ask because the issue tag header markup tags were removed.

I will still review but needed ask

alaa abbad’s picture

Issue summary: View changes
alaa abbad’s picture

Yes, I used an AI tool to help shorten the summary, and the headings were lost when I pasted it. I've restored them. I check and test everything I post, and the MR's fix and test are mine to answer for.

smustgrave’s picture

Not seeing how 'user.role.content_editor', is related to the path module missing though?