Problem/Motivation

Test coverage was written for SA-CORE-2026-008, but has not yet been added to core.

Proposed resolution

Add the test coverage.

Remaining tasks

NR.

Issue fork drupal-3633167

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

xjm created an issue. See original summary.

xjm’s picture

xjm
she/her
Primary language English
commented
Component: jsonapi.module » media system

Oops.

xjm opened merge request !17560

xjm’s picture

xjm
she/her
Primary language English
commented
Status: Active » Needs review
smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +Needs Review Queue Initiative

Reversed the MR from https://git.drupalcode.org/project/drupal/-/commit/b690beaf5e512136b5899...
Applied the test here and ran locally

Failed asserting that 'https://example.com/oembed?url=test' is identical to false.
/var/www/html/core/modules/media/tests/src/Unit/UrlResolverTest.php:80


Failed asserting that 'https://example.com/oembed?url=test' is identical to false.
/var/www/html/core/modules/media/tests/src/Unit/UrlResolverTest.php:80

2 and 3 failed while 1 passed, which was just the original test value. Kudos for turning updating that test that way. I probably would of made a separate one for no reason :)

Looks good.

catch’s picture

catch
he/him
Primary language English
commented
Version: main » 11.4.x-dev
Status: Reviewed & tested by the community » Fixed

Committed/pushed to main and cherry-picked back through to 11.4.x, thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

  • catch committed a2aeb0bc on 11.4.x 
    task: #3633167 Add test coverage for SA-CORE-2026-008

By: xjm
By:...

  • catch committed 7f9c951e on 11.5.x 
    task: #3633167 Add test coverage for SA-CORE-2026-008

By: xjm
By:...

  • catch committed b0c5ecab on 11.x 
    task: #3633167 Add test coverage for SA-CORE-2026-008

By: xjm
By:...

  • catch committed 65798296 on 12.0.x 
    task: #3633167 Add test coverage for SA-CORE-2026-008

By: xjm
By:...

  • catch committed 1e502a34 on main 
    task: #3633167 Add test coverage for SA-CORE-2026-008

By: xjm
By:...