Problem/Motivation

The search page design shows Category as tabs above the results and a Sort by dropdown beside the keyword box. The Rightup recipe adds both; the theme has no styling for them yet. A ticked category in the rail also does not look ticked: the base styles draw the box on a transparent background, so the white tick sits on white. The Date Published radios have the same problem.

Steps to reproduce

  1. Install The Rightup and search for "client".
  2. Tick Architecture in the Category list. The results narrow, but the box does not look ticked.

Proposed resolution

  • Category tabs: style the tabs facet as the design's tab row. The active tab is filled with the tertiary colour and white text, with a line under the row, and the row scrolls sideways on phones.
  • Sort by: show the sort links as a dropdown that stays a set of links, so a new sort keeps the chosen tab. Keyboard order follows the design: keywords, Search, Sort by.
  • Ticked state: checked facet boxes and the Date Published radios fill black with a white mark.
  • Tabs component: a row of plain links stays a list and only becomes a tablist when it has panes, so the search tabs do not report an accessibility error. This touches every page that uses Tabs.

Remaining tasks

  • ✅ File an issue
  • ✅ Addition/Change/Update/Fix
  • ❌ Testing to ensure no regression
  • ➖ Automated unit/functional testing coverage
  • ➖ Developer Documentation support
  • ➖ User Guide Documentation support
  • ❌ UX/UI designer responsibilities
  • ❌ Accessibility and Readability
  • ✅ Reviewed by a human
  • ✅ Code review by maintainers
  • ❌ Full testing and approval
  • ✅ Credit contributors
  • ❌ Review with the product owner
  • ✅ Update Release Notes
  • ✅ Release

User interface changes

  • Search page: Category tabs, a Sort by dropdown, and visible ticks in the rail.

All selected:

Search page with All selected

Architecture chosen: the tab is active and the same box is ticked in the rail.

Architecture tab active and ticked in the Category list

Sort by open:

Sort by dropdown open with Relevance and Newest

Phone, 390 px wide:

Search page on a phone with the Architecture tab active

API changes

  • N/A

Data model changes

  • N/A

Release notes snippet

  • Style the search page Category tabs and Sort by, and show ticked facet boxes.
Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

rajab natshah created an issue. See original summary.

  • rajab natshah committed 412d2e76 on 1.0.x
    feat: #3631966 Style the search page Category tabs and Sort by, and show...
rajab natshah’s picture

Screenshots after the change, on a fresh The Rightup install with a search for "client".

All selected:

Search page with All selected

Architecture chosen: the tab is active and the same box is ticked in the rail.

Architecture tab active and ticked in the Category list

Sort by open:

Sort by dropdown open with Relevance and Newest

Phone, 390 px wide:

Search page on a phone with the Architecture tab active

rajab natshah’s picture

Issue summary: View changes
rajab natshah’s picture

Assigned: rajab natshah » Unassigned
Issue summary: View changes
Status: Active » Fixed
Issue tags: +vartheme_bs5_rightup-1.0.7

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.