Problem/Motivation

Follow-up from #3471113: Update to selenium/standalone-chrome:134+

https://git.drupalcode.org/project/drupal/-/merge_requests/16706 used an approach of waiting for two animation frames after a button press to reduce (or possibly completely eliminate) random test failures in functional javascript tests.

Although it's a workaround, getting rid of functional js random failures is worth almost any workaround, so we should investigate more here. We should be able to use the repeat test job to run a commonly failing test with and without to see how things look both after #3471113: Update to selenium/standalone-chrome:134+ and with this change.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3631249

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

catch created an issue. See original summary.

mstrelan made their first commit to this issue’s fork.

mstrelan opened merge request !17493

mstrelan opened merge request !17494

mstrelan’s picture

mstrelan commented
Status: Active » Needs work

There are two MRs up, one with the workaround and one without. Both passed 100 times on two different classes that were reported in Slack to have random fails. Might need to try on some other classes that have higher failure rates.

catch’s picture

catch
he/him
Primary language English
commented

I think several of the js random failures tend to be related to timing issues when the gitlab runners are under load, especially the less frequent ones, which can make them very hard to reproduce with the 100 times test.