Problem/Motivation

Since #3630345: Preview as a switch on the Canvas, and in a new tab, instead of a split view, the islands of type IslandType::Floating sit in the header row of their panel: the viewport switcher, Highlight, Preview and Scaffold options. None floats anymore, but the enum, the profile form and the CSS still say so.

Proposed resolution

Rename the case IslandType::Secondary, value secondary, listed as Secondary controls in the profile form. The box pinned over a panel, left to contrib islands, follows with its class, slot and z-index token.

Remaining tasks

  • Review.
  • Publish the change record on merge.

User interface changes

The profile form lists Secondary controls instead of Floating controls.

API changes

IslandType::Floating becomes IslandType::Secondary. The wrapper class becomes db-island-secondary and the test IDs start with secondary_. The pinned box becomes db-island-secondary-controls, its slot view_secondary_controls, its token --db-z-secondary-controls. Renamed outright, as every API change before beta9, with a change record.

Data model changes

None: profiles store no island type.

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

mogtofu33 created an issue. See original summary.

mogtofu33’s picture

Assigned: mogtofu33 » pdureau
Status: Needs work » Needs review
mogtofu33’s picture

Assigned: pdureau » Unassigned
Status: Needs review » Needs work

  • mogtofu33 committed 1cb46430 on 1.0.x
    task: #3631052 Rename IslandType::Floating to IslandType::Secondary
    
    By...
mogtofu33’s picture

Status: Needs work » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

pdureau’s picture

Status: Fixed » Closed (fixed)