Problem/Motivation

The proposed GitLab CI checks report existing PHP coding-standard violations, JavaScript and CSS lint errors, and spelling findings.

Steps to reproduce

  1. Run Drupal PHPCS, ESLint, Stylelint and CSpell against the current 1.0.x branch.
  2. Observe coding-standard violations, lint errors and spelling findings.

Proposed resolution

Apply coding standards, fix JavaScript and CSS formatting, use US spelling and add a dictionary for valid project terms. Preserve formatter behavior and settings.

Two array-key errors are already addressed by #3628598; leave those blocks unchanged to avoid conflicts.

ESLint, Stylelint and CSpell pass. Drupal PHPCS passes with the pending token-help MR applied. Compatibility with all three pending MRs has been checked.

Service-injection recommendations and non-blocking JavaScript warnings are outside this issue.

Remaining tasks

Review and merge the MR.

Issue fork glightbox_media_video-3628807

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

nick hope created an issue. See original summary.

nick hope opened merge request !12

nick hope’s picture

nick hope commented
Assigned: nick hope » Unassigned
Issue summary: View changes
Status: Active » Needs review

  • nick hope committed b1abc1e8 on 1.0.x 
    chore: #3628807 Fix coding standards, lint errors and spelling

By:...
levmyshkin’s picture

levmyshkin
Location Novi Sad, Serbia
commented
Status: Needs review » Fixed

Thanks @nick hope! Reviewed and merged into 1.0.x.

Review notes:

  • Changes are formatting, docblock, lint and spelling only — ignoring whitespace, the PHP diff has no logic changes.
  • Drupal + DrupalPractice PHPCS goes from 51 errors / 9 warnings down to 2 errors / 4 warnings. The 2 remaining errors are the token-help #states arrays intentionally left for #3628598.
  • PHP lint passes; JS syntax check passes. Trailing commas in function calls are fine since the module requires Drupal 10.1+ (PHP 8.1+).
  • The MR applied as a clean fast-forward on top of the latest 1.0.x (after #3628580 and #3628653).

Committed as b1abc1e.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

levmyshkin’s picture

levmyshkin
Location Novi Sad, Serbia
commented
Status: Fixed » Closed (fixed)