Problem/Motivation
The podcast cards on the /podcasts listing print their titles as h3 straight under the page h1, so the heading outline skips h2 (WCAG 1.3.1 and 2.4.6). The Rightup's structure test fails on it.
Follow-up to #3627494: Podcast, show and episode pages: view rows, Read more, platform links and the design's hover and focus states. Related: #3627507: Podcast, show and episode pages after the design, on the show-and-episodes model.
Steps to reproduce
- Install The Rightup with podcast content.
- Open
/podcastsand list the headings: h1, then h3 for every card.
Proposed resolution
In views-view-fields--podcasts.html.twig, render the card title as h2 on the listing (all display) and keep h3 in More Podcasts (more), which sits under an h2. The visual size stays h3.
Remaining tasks
- ✅ File an issue
- ✅ Addition/Change/Update/Fix
- ❌ Testing to ensure no regression
- ➖ Automated unit/functional testing coverage
- ➖ Developer Documentation support
- ➖ User Guide Documentation support
- ➖ UX/UI designer responsibilities
- ✅ Accessibility and Readability
- ❌ Reviewed by a human
- ❌ Code review by maintainers
- ❌ Full testing and approval
- ❌ Credit contributors
- ❌ Review with the product owner
- ❌ Update Release Notes
- ❌ Release
User interface changes
- None visible. Only the heading level changes.
API changes
- N/A
Data model changes
- N/A
Release notes snippet
- Podcast card titles on the podcasts listing are h2, so the heading outline no longer skips a level.
Issue fork vartheme_bs5_rightup-3627726
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #3
rajab natshahComment #5
rajab natshah