Problem/Motivation

The phpcs, phpstan and cspell jobs fail on 1.0.x. They are allowed to fail, so new violations in merge requests go unnoticed.

Proposed resolution

  • cspell: add a .cspell.json that ignores extension/dist/ and adds the project's own words to a project dictionary.
  • phpcs: fix the reported violations.
  • phpstan: stop tests from using the deprecated PageRegion class directly, add the $cacheability parameter to the entity operation hooks, and fix the remaining errors.
  • Make the jobs blocking once they pass.

Issue fork canvas_translate-3627678

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

f0ns created an issue. See original summary.

f0ns opened merge request !13

f0ns’s picture

f0ns commented

MR !13 is ready for review.

All three lint jobs pass and are now blocking. phpstan-baseline.neon covers the 2 errors that #3620535: Add support for Page variants fixes. Delete it once that's in.

f0ns’s picture

f0ns commented
Status: Active » Needs review

  • lauriii committed a89a0ea8 on 1.0.x authored by f0ns 
    task: #3627678 Fix the phpcs, phpstan and cspell failures in CI

By:...
lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Status: Needs review » Fixed

Thank you! This is a nice clean up 🧹

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.