Problem/Motivation

Storybook shows eleven top-level groups where the reference Storybook (storybook.demo.varbase.vardot.com) shows ten. The extra one is Card, holding five components whose story titles say Card/ instead of Cards/: Article Teaser, Card Slider, Horizontal Text Icon Card, Podcast Card and Text Number Card. Nine other card components are correctly under Cards.

The reference Storybook has no Card group at all, and its Cards group count matches this theme's Cards exactly, which indicates the five are later additions that were filed under a mistyped group. Verified against 1.0.x at commit 6e974b0.

Steps to reproduce

  1. Open Storybook and count the top-level groups in the sidebar: eleven.
  2. Both Card and Cards are present.
  3. Expand Card: the five components above sit there instead of under Cards.

Proposed resolution

Change title: 'Card/...' to title: 'Cards/...' in the five *.stories.twig sources and regenerate.

Verified: ten top-level groups with names identical to the reference, and Cards goes from 63 to 85 entries. The Foundation and Getting Started ordering already matched the reference beforehand.

A merge request will follow.

Remaining tasks

  • ✅ File an issue
  • ❌ Addition/Change/Update/Fix
  • ❌ Testing to ensure no regression
  • ➖ Automated unit/functional testing coverage
  • ➖ Developer Documentation support
  • ➖ User Guide Documentation support
  • ➖ UX/UI designer responsibilities
  • ➖ Accessibility and Readability
  • ❌ Reviewed by a human
  • ❌ Code review by maintainers
  • ❌ Full testing and approval
  • ❌ Credit contributors
  • ❌ Review with the product owner
  • ❌ Update Release Notes
  • ❌ Release

User interface changes

  • The stray Card group disappears from the Storybook sidebar and its five components join Cards.

API changes

  • N/A

Data model changes

  • N/A

Release notes snippet

  • Moved five components from a stray Card group into Cards in Storybook.
Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

rajab natshah created an issue. See original summary.

rajab natshah’s picture

Status: Active » Needs review

  • rajab natshah committed 4cb3f549 on 1.0.x
    task: #3627277 Move the five stray Card stories into the Cards group
    
rajab natshah’s picture

Status: Needs review » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.