Problem/Motivation

Five small things say something wrong:

  • The SseState::collection() docblock says the store is resolved before the stream's first yield. ApiSseController::sse() yields first, and the store is resolved on the first read after it. It works because KeepSessionOpenEventStreamResponse keeps the session open.
  • InstanceTranslationSubscriber says param conversion runs at priority 5000 on kernel.request. 5000 is the priority of the route enhancer. Conversion runs in the router listener, at 32.
  • TextareaWidget has @toto for @todo.
  • .env.dist names PlaywrightTestSetup.php. The file is DisplayBuilderTestSetup.php.
  • zensical.toml sets edit_uri on main. The branch is 1.0.x, so the edit links of the docs site point to a branch that does not exist.

Proposed resolution

Fix the comments and the two paths. No behavior change.

User interface changes

None. The edit links of the docs site work again.

API changes

None.

Data model changes

None.

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

mogtofu33 created an issue. See original summary.

  • mogtofu33 committed 844c54b8 on 1.0.x
    chore: #3627246 Fix stale docblocks, a todo typo, and the paths in .env....
mogtofu33’s picture

Assigned: mogtofu33 » Unassigned
Status: Active » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.