Problem/Motivation

Navigation Top Bar was merged into Navigation in 11.3.

An update hook in 11.3 should have uninstalled any remaining usage of this module.

We should be able to cleanly delete this module from Drupal 12.

Steps to reproduce

Proposed resolution

Delete core/modules/navigation/modules/navigation_top_bar.

Remaining tasks

Check that the update hook landed in 11.3 and so upgrades to 12 are safe.

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3627057

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

longwave created an issue. See original summary.

shank115 made their first commit to this issue’s fork.

shank115 opened merge request !17303

shank115’s picture

shank115 commented
Status: Active » Needs review

Opened an MR that removes core/modules/navigation/modules/navigation_top_bar (only the obsolete .info.yml was left).

Checked the remaining tasks:

  • navigation_post_update_uninstall_navigation_top_bar() was added for 11.3 and uninstalls the module. On main it's already listed in navigation_removed_post_updates() as 12.0.0.
  • Upgrading to 12 is safe. Sites that haven't run that post update are blocked by the removed post update requirements check, so they have to update to 11.x first. The module can't be installed again after that, since obsolete modules are rejected by ModuleInstaller.
dcam’s picture

dcam commented
Status: Needs review » Reviewed & tested by the community

Both the submodule and the post-update function that uninstalls it are in the 11.2.x branch.

There isn't much to review in the MR. All submodule files are deleted. In fact, the entire core/modules/navigation/modules directory is now gone because that info file was the only thing in it.

I grepped Core for any lingering mentions of the submodule's name, 'navigation_top_bar'. The only one left is the removed post-update function name.

  • catch committed 7152f54f on main 
    task: #3627057 Remove the navigation_top_bar module from core

By:...
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to main, thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Version: main » 12.0.x-dev
Status: Fixed » Reviewed & tested by the community

Can be cherry picked to 12.0.x too!

xjm’s picture

xjm
she/her
Primary language English
commented
Issue tags: +12.0.0 release notes, +12.0.0-beta2 release notes, +Needs change record

  • catch committed 0f0b0d6d on 12.0.x 
    task: #3627057 Remove the navigation_top_bar module from core

By:...
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Did the cherry-pick.

I don't think this needs to go into the release notes because it was only possible for this module to be uninstalled since approximately 11.2, so there should be nothing for site owners to respond to. Added a change record though since I couldn't immediately find the one where we made it obsolete in the first place. It never had any code in it, was always a .info.yml only feature flag module.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.