Problem/Motivation

@vardot/varbase-e2e 2.0.6 is released. It fixes smartSettle waiting forever on a page whose network never goes idle, which showed up as a bare function timed out after 45s.

Two things in this project need attention with it. The timeout: 60000 in cucumber.js has no effect, because varbase-e2e's own setDefaultTimeout() overrides the config key, so the suite has been running on 45s. And the 📊 Create reports job installs varbase-e2e with no version at all.

Proposed resolution

Raise the floor in package.json to ^2.0.6, pin the report job's install to the same floor, set the step timeout through VARBASE_E2E_STEP_TIMEOUT, and guard the functional job's report step so it prints one line instead of a stack trace when the tests never ran.

Remaining tasks

  • âś… Update the version floor and the CI pin
  • âś… Make the step timeout take effect
  • âś… Guard the report step
  • ❌ Code review by maintainers

User interface changes

  • None.

API changes

  • None.

Data model changes

  • None.

Release notes snippet

  • Updated the Varbase functional testing suite to @vardot/varbase-e2e 2.0.6, and fixed the step timeout in cucumber.js, which had no effect.

AI-Generated: Yes

Issue fork educare-3625377

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

rajab natshah created an issue. See original summary.

rajab natshah’s picture

Issue summary: View changes

  • rajab natshah committed d5cdf070 on 1.0.x
    task: #3625377 Update @vardot/varbase-e2e to 2.0.6 and make the step...
rajab natshah’s picture

Assigned: Unassigned » josebc
Status: Active » Needs review
Issue tags: +educare-1.0.4

âś… Released educare-1.0.4

rajab natshah’s picture

Assigned: josebc » mohammed j. razem
rajab natshah’s picture

Assigned: mohammed j. razem » Unassigned
Status: Needs review » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.