Problem
Two tests read a file the module ships and assert on its words, which tests nothing about behavior and fails on an edit that changes no behavior.
tests/src/Unit/InitiatorLookupCostTestreadsLocalOrchestraClient.phpas a string, cuts out the body oflistInstances()and asserts it containstoWireNames(and nottoWireName(. Renaming either method, or resolving the page through a helper, fails it while the behavior it guards (one lookup per page rather than one per row) is untouched; and a per-row lookup routed through a differently named method passes it.ViewsMenuLinksTest::testTheReadmeNamesThePagesThisModuleShipsasserts that the README text contains each shipped view's path. A README is prose; a stale README is fixed in the README.
Proposed resolution
Delete the README assertion. Replace the source read with the behavioral test it stands in for: a kernel test that lists a page of runs with several initiators and asserts the account lookups do not grow with the page (count the queries, or the calls to the identity scheme), so a per-row lookup fails it whatever the method is called.
AI disclosure: this issue was drafted by Claude Code from an automated file-by-file audit of the module; the code and tests in the merge request are written by Claude Code, with the affected test classes run locally and the whole suite run by the project pipeline. The maintainer reviews and merges.
Issue fork orchestra-3624694
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #3
mably commentedComment #5
mably commented