Problem/Motivation

Need to update our fixtures to not use Olivero or Claro to fully deprecate and remove those

Steps to reproduce

Proposed resolution

Use Stark instead of Claro in both dumps.

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3624072

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

smustgrave created an issue. See original summary.

quietone’s picture

quietone commented
Title: Update test fixtures to not use olivero or claro » Update test fixtures to not use claro

There is a separate issue for Olivero, #3623927: Remove Olivero from database dumps

smustgrave’s picture

smustgrave commented
Component: other » Claro theme

smustgrave opened merge request !17176

smustgrave’s picture

smustgrave commented

Pulled in the changes from #3623927: Remove Olivero from database dumps

Disclosure used AI to help write drupal-11.3.0.theme-default-admin.php.

Issue it's help address is that in 11.3 default_admin wasn't in the filesystem. So 0 idea how we can update the fixtures to use default_admin over claro if it doesn't exist.

So the script helps do some database stuff then in the test it installs default_admin and sets the config it needs.

quietone’s picture

quietone commented
Parent issue: » #3576668: [meta] Tasks to deprecate Claro

catch made their first commit to this issue’s fork.

catch’s picture

catch
he/him
Primary language English
commented
Status: Active » Needs work

We should be swapping claro for stark in the dump itself, that way there won't be a need to rewrite in each test.

quietone’s picture

quietone commented
Title: Update test fixtures to not use claro » Remove claro from database dumps

I like to have at least 'dump' in the table to help with searching the logs.

quietone’s picture

quietone commented
Assigned: smustgrave » Unassigned
Issue summary: View changes
Status: Needs work » Needs review
smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Spoke to quietone on slack and brought up a good point about not using default admin and stark was fine, as you also mentioned @catch so my solution was incorrect.

This looks good!

  • catch committed 42f58b39 on main 
    task: #3624072 Remove claro from database dumps

By: smustgrave
By:...
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to main, thanks!

Opened #3624353: Add an 11.4.0 database dump with default_admin installed so that we'll eventually have a database dump for testing upgrade paths involving default_admin / themes other than stark.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.