Problem/Motivation

The conventions entity declares ten roles a site can fill in, and two of them - special_pages and reviews_rating - are read by nothing. What actually decides those two is configuration under myrest.settings: the special pages service reads special_page_nodes, and the reviews aggregate reads reviews_rating. So one fact has two declared homes and only one of them is wired, and a site that fills the convention in - on a page that offers it - changes nothing at all. That is worse than an absent feature: it is a feature that appears to work.

Proposed resolution

  • Decide where each of the two belongs. The model is the direction of this project, so reading them from the conventions and treating the settings key as the fallback is the expected answer - but it is a decision, not a refactor.
  • Whichever way it goes, only one of the two homes stays authoritative, and the other is documented as the fallback or removed.
  • A role that stays in the list gets a test that filling it changes a response; a role that leaves the list leaves the conventions page with it.

Remaining tasks

Everything.

Issue fork myrest-3623983

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

sergeydruua created an issue. See original summary.

  • sergeydruua committed 1cbc0da1 on 1.0.x
    Issue #3623983: Give the unread convention roles a reader, or take them...
sergeydruua’s picture

Status: Active » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

sergeydruua’s picture

Status: Fixed » Closed (fixed)