Problem/Motivation

When editing a node with multiple files to a file field, the tabledrag UI is not correct. The drag handle should be on the left.

CommentFileSizeAuthor
#7 after-1-tabledrag-handle.png100.11 KBironnuts
#2 Edit_Test_node_test___Drush_Site-Install-2.png231.7 KBmherchel
Edit_Test_node_test___Drush_Site-Install.png37.73 KBmherchel

Issue fork drupal-3623407

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

mherchel created an issue. See original summary.

mherchel’s picture

mherchel
he/him
Primary language English
Location Gainesville, FL, US
commented
Issue summary: View changes
StatusFileSize
new Edit_Test_node_test___Drush_Site-Install-2.png231.7 KB
mherchel’s picture

mherchel
he/him
Primary language English
Location Gainesville, FL, US
commented
Issue summary: View changes

Note this is only when editing a node. Not when creating a node. Updating IS

mherchel opened merge request !17141

mherchel’s picture

mherchel
he/him
Primary language English
Location Gainesville, FL, US
commented
Status: Active » Needs review

There was a lot of code in this file that was unnecessary or unused... likely because the tabledrag CSS was refactored during the CSS consolidation process.

This should be good to go.

gábor hojtsy made their first commit to this issue’s fork.

ironnuts’s picture

ironnuts commented
StatusFileSize
new after-1-tabledrag-handle.png100.11 KB

I have manually tested. See screenshot after-1. The handles are aligned to the left. This is the css now:

.table-file-multiple-widget {
  & .tabledrag-cell-content {
    & > * {
      display: block;
    }
  }
}
ironnuts’s picture

ironnuts commented
Status: Needs review » Reviewed & tested by the community

Checked the code including the latest commit by goba. edit: Have tested the tabledrag functionality also. The files can be dragged and the node saved. LGTM. RTBTC.

catch made their first commit to this issue’s fork.

catch’s picture

catch
he/him
Primary language English
commented
Version: main » 11.x-dev
Status: Reviewed & tested by the community » Patch (to be ported)

Nice to see so much CSS removed.

Needed a rebase for performance tests but I did that and pushed to the branch here prior to commit.

Committed/pushed to main, thanks!

  • catch committed 3926319c on main 
    fix: #3623407 Broken tabledrag UI when uploading multiple files in Admin...

smustgrave made their first commit to this issue’s fork.

smustgrave opened merge request !17168

smustgrave’s picture

smustgrave commented
Status: Patch (to be ported) » Reviewed & tested by the community

Clean backport.

ironnuts’s picture

ironnuts commented

smustgrave Great!

godotislate’s picture

godotislate
he/him
commented

Merge conflict from #3583516: Breadcrumb separators are exposed to the accessibility tree.

It might make sense to hold off resolving until after #3623385: Admin theme's status report styling is off is in.

godotislate’s picture

godotislate
he/him
commented
Status: Reviewed & tested by the community » Needs work
godotislate’s picture

godotislate
he/him
commented

#3623385: Admin theme's status report styling is off is in, so this can probably go next after conflict resolution.

smustgrave’s picture

smustgrave commented
Status: Needs work » Reviewed & tested by the community

Done

  • godotislate committed 33efdeae on 11.x 
    fix: #3623407 Broken tabledrag UI when uploading multiple files in Admin...
godotislate’s picture

godotislate
he/him
commented
Status: Reviewed & tested by the community » Fixed

Committed 33efdea and pushed to 11.x. Thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.