The styling is off within the "General System Information" within the Status Report page

Right now:

With proper styling (in dev tools)

Issue fork drupal-3623385

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

mherchel created an issue. See original summary.

mherchel’s picture

Status: Active » Needs review
StatusFileSize
new58.17 KB

This is ready. Fixed, and I also updated the PHP Logo (previously it was just a generic file logo).

gábor hojtsy made their first commit to this issue’s fork.

gábor hojtsy’s picture

Status: Needs review » Reviewed & tested by the community
StatusFileSize
new471 KB

Changes look good, well scoped to the status report. Checked on Tugboat too:

  • catch committed cb786012 on main
    fix: #3623385 Admin theme's status report styling is off
    
    By: mherchel...
catch’s picture

Version: main » 11.x-dev
Status: Reviewed & tested by the community » Patch (to be ported)

Committed/pushed to main, thanks!

Will need an 11.x backport MR due to the performance test changes.

One question for a possible follow-up - do we really need the PHP icon svg in icons.css given it's only ever going to be loaded on the status report? If it wasn't in there, the performance test wouldn't have needed updating. But no idea what it would take to split things out.

mherchel’s picture

do we really need the PHP icon svg in icons.css

Probably not. TBH, I think we should not be inlining SVGs. Can't find the issue to cross-link though,

catch’s picture

smustgrave made their first commit to this issue’s fork.

smustgrave’s picture

Status: Patch (to be ported) » Reviewed & tested by the community

Backported

godotislate’s picture

Status: Reviewed & tested by the community » Needs work
smustgrave’s picture

Status: Needs work » Reviewed & tested by the community

Rebased, seems unrelated js failure.

  • godotislate committed ed5bcd2a on 11.x
    fix: #3623385 Admin theme's status report styling is off
    
    By: mherchel...
godotislate’s picture

Status: Reviewed & tested by the community » Fixed

Committed ed5bcd2 and pushed to 11.x. Thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.