Problem/Motivation

MyrestLogSettingsForm::validateForm() and submitForm() name their form state $formState. Both are called by position, so nothing breaks today, but $form_state is the name Drupal binds by name wherever a form is a route — in buildForm() — and a later edit that carries the local name over breaks the page with "requires the $formState argument that could not be resolved". That is exactly what happened in a sibling project.

Proposed resolution

  • Use $form_state in every method of the project that receives a form state.

Remaining tasks

Everything.

Issue fork myrest-3623208

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

sergeydruua created an issue. See original summary.

sergeydruua opened merge request !167

  • sergeydruua committed 9cbd731e on 1.0.x 
    Issue #3623208: Name the form state $form_state in the log settings form
sergeydruua’s picture

sergeydruua commented
Status: Active » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

sergeydruua’s picture

sergeydruua commented
Status: Fixed » Closed (fixed)