Three site-wide settings decide what the engine does when a branch fails or dead-ends, and none of them is reachable from the Orchestra settings page, which offers the other eight.

  • on_dead_end: raise an incident on a branch that took none of its outgoing flows, or complete it quietly.
  • on_unrecoverable_failure: raise an incident and leave the run going, or fail the whole run.
  • max_advance_attempts: how many failed advances a token gets before it is dead-lettered.

All three ship in config/install/orchestra.settings.yml, are typed and constrained in the config schema, and are read by IncidentStore. The only way to change one is to edit configuration by hand or write an update hook. docs/troubleshooting.md sends a site builder to on_dead_end: complete as the site-wide escape hatch, and docs/incidents.md documents all three as raw YAML, which is the whole audience for a setting nobody can reach from a page.

Proposed resolution. Add the three to SettingsForm, in the wording the schema and the documentation already use, with the same validation the numeric settings on that form get, and a functional test that saves each of them and reads the stored configuration back.

Found by the whole-tree audit of 1.x at 7c9f1b2a.

AI-Generated: Yes (Claude Code was used to help draft this issue summary and to write the code and tests on the merge request. I reviewed and ran the work myself before posting it.)

Issue fork orchestra-3623042

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

mably created an issue. See original summary.

mably’s picture

Status: Active » Needs review

  • mably committed a8ed3361 on 1.x
    task: #3623042 Offer the dead-end, unrecoverable-failure and retry-...
mably’s picture

Status: Needs review » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.