A whole-tree audit of 1.x at 7c9f1b2a found three surfaces that print a machine name to somebody reading it for its meaning, while the human label is already resolved elsewhere in the same module.

The audience of a pooled task. WorkItemManager::getHolderLabel() falls back to the stored candidate tokens when nobody holds the item, and prints them verbatim: Offered to: role:reviewer, user:12. Both surfaces that render it are ones an operator reads constantly, the task inbox (InboxController) and the Views Held by column (WorkItemHolder). Every audience plugin already knows how to label its own dimension; nothing asks it to.

The name of a run. ProcessInstance::label() builds its label out of getDefinitionId(), so the My Orchestra actions page names a run leave_request #42. One click away, InstanceReadController titles the same run with the workflow label, Leave request. Two surfaces, one run, two names.

The admin instance summary. OrchestraUiController::instance() prints the raw engine state, the workflow machine name and the tenant machine name. ProcessInstance::getStateLabels() exists to be the single source of truth for the first of those and has five other callers, and the workflow entity is loaded four lines below the line that prints its id. On a French site the summary reads Etat : running.

Proposed resolution. Resolve each of them through the labeller that already exists: the audience plugins for the candidate tokens, getStateLabels() for the state, and the workflow and tenant entities for their own labels. Each one gets a test that fails on the machine name and passes on the label.

AI-Generated: Yes (Claude Code was used to help draft this issue summary and to write the code and tests on the merge request. I reviewed and ran the work myself before posting it.)

Issue fork orchestra-3623041

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

mably created an issue. See original summary.

mably’s picture

Status: Active » Needs review

  • mably committed d9d1a648 on 1.x
    fix: #3623041 Label the audience, the engine state and the workflow a...
mably’s picture

Status: Needs review » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.