Problem/Motivation

Toolbar module references various icons relative to its position in core, which won't work when it's in contrib.

Steps to reproduce

Proposed resolution

Copy the icons into toolbar module and update the references.

We should also evaluate whether we can remove those icons from core (possibly in this issue, possibly a separate follow-up).

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3622941

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

catch created an issue. See original summary.

longwave made their first commit to this issue’s fork.

longwave opened merge request !17121

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Active » Needs review

MR!17121 can be applied to main and 11.x to copy all icons into toolbar module and update their references.

Then in a main-only followup we can delete these icons (and another 27 more that are no longer referenced)

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Priority: Normal » Critical

This needs to be done before we remove toolbar.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Parent issue: » #3484850: [meta] Tasks to deprecate Toolbar module
abenbow’s picture

abenbow
He/Him/His
Primary language English
commented
Status: Needs review » Reviewed & tested by the community

This MR appears to be good. I've done some manual review and testing using a fresh Drupal instance on my local to confirm that:

  • The icons have all been moved to the proper place inside of the toolbar module, and
  • Rebuilding the theme css after moving the icons to the wrong place does in fact break the icons (proving they worked in the first place)

I didn't encounter any 404's or broken icons during regular usage, which to my mind says that this was resolved properly using the MR.

  • catch committed d5a06852 on 11.x 
    task: #3622941 Copy icons into toolbar

By: catch
By: longwave
By:...

  • catch committed a4fdb93b on main 
    task: #3622941 Copy icons into toolbar

By: catch
By: longwave
By:...
catch’s picture

catch
he/him
Primary language English
commented
Version: main » 11.x-dev
Status: Reviewed & tested by the community » Fixed

Committed/pushed to main and 11.x, thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.