Problem/Motivation

Add the missing Breakpoints definition to allow their usage in Drupal API.

Breakpoints official DSFR documentation: https://www.systeme-de-design.gouv.fr/version-courante/fr/fondamentaux/g...

Issue fork ui_suite_dsfr-3622291

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

mogtofu33 created an issue. See original summary.

mogtofu33 opened merge request !225

mogtofu33’s picture

mogtofu33 commented
Assigned: mogtofu33 » Unassigned
Status: Needs review » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

just_like_good_vibes’s picture

just_like_good_vibes
Location PARIS
commented

Hello,
Thanks @mogtofu33 for adding the breakpoints. The min-width values match the DSFR grid page, the DSFR CSS and the DSFR JavaScript exactly.

I have questions about the four max-width entries. What are they for, and where do the values come from? DSFR does not define any. In 1.15.2 the DSFR CSS only uses min-width media queries (36em, 48em, 62em, 78em), and its JavaScript breakpoints only test min-width too. What was the goal?

just_like_good_vibes’s picture

just_like_good_vibes
Location PARIS
commented
Status: Fixed » Needs review

mogtofu33 opened merge request !226

mogtofu33 changed the visibility of the branch 3622291- to hidden.

mogtofu33 changed the visibility of the branch 3622291-breakpoints-no-max to hidden.

  • mogtofu33 committed 26a84e7b on 1.x 
    refactor: #3622291 keep only breakpoints min and remove max
mogtofu33’s picture

mogtofu33 commented

It was from ui_suite_bootstrap breakpoints probably legacy Bootstrap 3 or something with responsive_image, anyway it seems you're right and they can be removed. I merge directly to avoid keeping them in dev but still keep in review.

just_like_good_vibes’s picture

just_like_good_vibes
Location PARIS
commented
Status: Needs review » Fixed

thanks, i will put a new tag with the breakpoints (updated).

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.