Problem/Motivation

Part of deprecating Claro

Steps to reproduce

Proposed resolution

These should be the tests to change.

  • core/tests/Drupal/FunctionalTests/Core/Recipe/StandardRecipeInstallTest.php
  • core/tests/Drupal/FunctionalTests/Core/Recipe/StandardRecipeTest.php
  • core/tests/Drupal/FunctionalTests/Installer/DistributionProfileExistingSettingsTest.php
  • core/tests/Drupal/FunctionalTests/Installer/DistributionProfileTest.php
  • core/tests/Drupal/FunctionalTests/Installer/DistributionProfileTranslationQueryTest.php
  • core/tests/Drupal/FunctionalTests/Installer/DistributionProfileTranslationTest.php
  • core/tests/Drupal/FunctionalTests/Installer/InstallerTest.php
  • core/tests/Drupal/FunctionalTests/Installer/MultipleDistributionsProfileTest.php
  • core/tests/Drupal/FunctionalTests/Installer/StandardInstallerTest.php

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3622220

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

quietone created an issue. See original summary.

quietone opened merge request !17073

quietone’s picture

quietone commented
Status: Active » Needs review
quietone’s picture

quietone commented

Rather straightforward now that #3618971: Use Admin theme in installer was committed.

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Change LGTM. Seem to be number of failures seeing on #3582101: Make Admin the default theme in profiles and recipes

godotislate’s picture

godotislate
he/him
commented
Status: Reviewed & tested by the community » Needs review

Q about code comment on the MR. The standard profile does not install default_admin. It still installs claro.

smustgrave’s picture

smustgrave commented

There’s another ticket about changing all those

godotislate’s picture

godotislate
he/him
commented

Right, but changing the comment from claro to default_admin is inaccurate, because as yet, the standard profile still installs claro and not default_admin.

quietone’s picture

quietone commented

Yes, I missed that comment. It is fixed now and tests are passing.

godotislate’s picture

godotislate
he/him
commented
Status: Needs review » Reviewed & tested by the community

Back to RTBC.

amateescu’s picture

amateescu commented
Version: main » 11.x-dev
Status: Reviewed & tested by the community » Patch (to be ported)

Committed 111eb83 and pushed to main. Thanks!

In 11.x the theme in core/tests/Drupal/FunctionalTests/Installer/DistributionProfileExistingSettingsTest.php is olivero, so I'm not sure what we want to do there..

  • amateescu committed 111eb83c on main 
    task: #3622220 Use Admin theme in installer related tests

By: quietone...

quietone opened merge request !17099

quietone’s picture

quietone commented

Let's change the use of Olivero core/tests/Drupal/FunctionalTests/Installer/DistributionProfileExistingSettingsTest.php here. That fits the scope of this issue, as per the title, even though this is in the Claro component.

quietone’s picture

quietone commented
Status: Patch (to be ported) » Needs review

11.x branch available and tests are passing

godotislate’s picture

godotislate
he/him
commented
Status: Needs review » Reviewed & tested by the community

11.x backport diff looks the essentially same as main diff. Noted that we're replacing olivero (instead of claro) with default_admin in 11.x, per #14.

  • catch committed ad1762a5 on 11.x 
    task: #3622220 Use Admin theme in installer related tests

By: quietone...
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed the backport to 11.x, thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.