Problem/Motivation

This module works by using a SearchApiProcessor plugin which acts in the 'add_properties' processing stage to add further properties to the SearchAPI 'General' datasource.

However, these are given labels which are just the field label.

If a search index has multiple datasources for multiple entity type, and some of these fields have the same label, it is not possible to determine which is the correct field.

Even if the field labels are different, it is still confusing and difficult to try to identify the correct field:

            $file_elements[$property->getName()] = $property->getLabel();

This can produce several items that just say, for example:

> Search api attachments: Media

Steps to reproduce

Proposed resolution

Add the datasource label, and if the property is being obtained over a media reference, specify that too.

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork search_api_attachments-3621434

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

joachim created an issue. See original summary.

joachim opened merge request !53

joachim’s picture

joachim commented
Status: Active » Needs review
joachim’s picture

joachim commented

Though actually -- this might be intentional, as fields aren't distinguished by entity type. Though that is perhaps a bug in itself.

izus’s picture

izus commented
Status: Needs review » Fixed

Thanks, this is now merged

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

izus’s picture

izus commented
Status: Fixed » Closed (fixed)

and released 10.0.11