Problem/Motivation
Updating to @vardot/varbase-e2e 2.0.4 breaks this test suite: 4 of the 32 scenarios stop with Multiple step definitions match. The library now ships the same step this recipe defines locally, so Cucumber sees two definitions for one sentence and will not guess:
Then I am denied access to "/admin/config/ai/figma"- Ours:
tests/step-definitions/ai-figma.steps.js:89 - The library's:
navigation.steps.js:264
Keep the library one. It passes on any refusal a site can give — 403, 404, an access-denied page, or a redirect to the log-in form — and it is documented in docs/steps/navigation.md. Ours only checked the status code.
Steps to reproduce
- On
1.0.x, runnpm installso@vardot/varbase-e2eresolves 2.0.4. - Run
npx cucumber-js --dry-run. No site, no browser: the run stops before that.
32 scenarios (4 ambiguous, 28 skipped) 149 steps (4 ambiguous, 145 skipped)
Proposed resolution
- Delete the local step (and its doc block) from
tests/step-definitions/ai-figma.steps.js. Nothing else in that file changes. - Require
@vardot/varbase-e2e^2.0.4and refreshpackage-lock.json. - No feature file changes: the sentences are identical.
Dry-run after the change: 32 scenarios, 149 steps, nothing ambiguous, nothing undefined. The browser suite needs a live site, so CI is what confirms the scenarios still pass.
Remaining tasks
- ✅ File an issue
- ✅ Addition/Change/Update/Fix
- ✅ Testing to ensure no regression
- ➖ Automated unit/functional testing coverage
- ➖ Developer Documentation support
- ➖ User Guide Documentation support
- ➖ UX/UI designer responsibilities
- ➖ Accessibility and Readability
- ❌ Reviewed by a human
- ❌ Code review by maintainers
- ❌ Full testing and approval
- ❌ Credit contributors
- ❌ Review with the product owner
- ✅ Update Release Notes
- ✅ Release
User interface changes
- None. This is the test suite only.
API changes
- None.
Data model changes
- None.
Release notes snippet
- Test suite: the access-denied step now comes from @vardot/varbase-e2e 2.0.4 instead of a local copy.
Issue fork varbase_ai_figma-3621380
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #3
rajab natshahComment #5
rajab natshah