Problem/Motivation

https://git.drupalcode.org/issue/drupal-3613882/-/jobs/11964276

Fail          8.943s testEmphasis                                                                    
Pass          6.997s testEmphasisArbitraryHtml                                                       
Failure              *** Process execution output ***                                                
    PHPUnit 12.5.17 by Sebastian Bergmann and contributors.
    
    Runtime:       PHP 8.5.10
    Configuration: /builds/core/phpunit.xml.dist
    
    F.                                                                  2 / 2 (100%)
    
    HTML output was generated.
    http://localhost/subdirectory/sites/simpletest/browser_output/Drupal_Tests_ckeditor5_FunctionalJavascript_EmphasisTest-1-76223404.html
    http://localhost/subdirectory/sites/simpletest/browser_output/Drupal_Tests_ckeditor5_FunctionalJavascript_EmphasisTest-2-76223404.html
    http://localhost/subdirectory/sites/simpletest/browser_output/Drupal_Tests_ckeditor5_FunctionalJavascript_EmphasisTest-3-55609641.html
    http://localhost/subdirectory/sites/simpletest/browser_output/Drupal_Tests_ckeditor5_FunctionalJavascript_EmphasisTest-4-55609641.html
    
    
    Time: 00:16.811, Memory: 16.00 MB
    
    Emphasis (Drupal\Tests\ckeditor5\FunctionalJavascript\Emphasis)
     ✘ Emphasis
       ┐
       ├ Behat\Mink\Exception\ExpectationException: The string "This is a test!" was not found anywhere in the HTML response of the current page.
       │
       │ /builds/vendor/behat/mink/src/WebAssert.php:888
       │ /builds/vendor/behat/mink/src/WebAssert.php:363
       │ /builds/core/tests/Drupal/Tests/WebAssert.php:569
       │ /builds/core/modules/ckeditor5/tests/src/FunctionalJavascript/EmphasisTest.php:142
       ┴
     ✔ Emphasis arbitrary html
    
    FAILURES!
    Tests: 2, Assertions: 21, Failures: 1.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3620770

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

joelpittet created an issue. See original summary.

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Parent issue: #3616094: [random test failure] CKEditor5Test::testEmphasis and ::testExistingContent » #2829040: [meta] Known intermittent, random, and environment-specific test failures
Related issues: +#3616094: [random test failure] CKEditor5Test::testEmphasis and ::testExistingContent
joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Title: [random test failure] CKEditor5Test::testEmphasisArbitraryHtml » [random test failure] EmphasisTest::testEmphasis

I miss-read the error it's EmphasisTest::testEmphasis() failing.

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Status: Active » Needs review

joelpittet opened merge request !16980

ironnuts’s picture

ironnuts commented

I have reviewed the code as best I can. I think the test failure in media_library module is unrelated. I have read the parent issue and I see that this test file was not covered by the parent fix. joelpittet perhaps could try re-running the pipeline to see if the test failure goes away?

This is a one line fix so seems ok to try RTBTC.

ironnuts’s picture

ironnuts commented
Status: Needs review » Reviewed & tested by the community
joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented

@oily, thanks yes the test isn't showing the same error as the reported pipeline I saw it in.

I ran the test ~36 times locally without the fix and ran into this one 10 times! There was a less frequent failure (2 times) where I got a HTTP 403 error... didn't look into that one... and when I pushed this, it failed so far in 2 different ways... I didn't want to chase any more rabbits 🐰 today, so I am keeping this focused.

ironnuts’s picture

ironnuts commented

Re: #8

I didn't want to chase any more rabbits 🐰 today, so I am keeping this focused.

+1!

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented

Test passed 100x here https://git.drupalcode.org/issue/drupal-3620770/-/jobs/11984753

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Version: main » 11.x-dev
Status: Reviewed & tested by the community » Fixed

Committed and pushed 4cf55e73686 to main and 7c1b9233191 to 11.x. Thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

  • longwave committed 7c1b9233 on 11.x 
    test: #3620770 [random test failure] EmphasisTest::testEmphasis

By:...

  • longwave committed 4cf55e73 on main 
    test: #3620770 [random test failure] EmphasisTest::testEmphasis

By:...
longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Version: main » 11.x-dev
Status: Reviewed & tested by the community » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.