Problem/Motivation
Two defects in the footer menu that the site template ships, both visible to an anonymous visitor on a fresh install.
1. The footer links to a page that does not exist. A footer menu link points at /terms-and-conditions, but no alias and no entity exist for it anywhere in the template. The link is a hard 404. Querying the alias table on a fresh install returns only /privacy-policy:
drush sqlq "SELECT alias FROM path_alias WHERE alias LIKE '%terms%' OR alias LIKE '%privacy%'" /privacy-policy
2. "Privacy policy" is duplicated in the footer menu, as two separate links with two different capitalisations, "Privacy policy" and "Privacy Policy". Both resolve to /privacy-policy, and both return 404 to an anonymous visitor because the node that drupal_cms_privacy_basic imports is unpublished:
drush sqlq "SELECT nid, status, title FROM node_field_data WHERE type='page'" 1 0 Privacy policy 2 0 Accessibility Tools demo page
Steps to reproduce
- Install the site template on Varbase 11.
- Log out.
- Look at the footer menu. Note two "Privacy policy" entries differing only in capitalisation, plus a "Terms and Conditions" entry.
- Follow each of them. All three return 404.
Proposed resolution
- Remove the duplicate "Privacy Policy" footer menu link, keeping one entry with one capitalisation.
- Either ship a published Terms and Conditions page at
/terms-and-conditions, or remove the footer link until there is a page for it. - For the privacy page itself, publish a page the template owns at
/privacyand point the link and the consent banner at it. Core recipes import content withExisting::Skip, so the node thatdrupal_cms_privacy_basicships unpublished cannot be republished from this template.
Remaining tasks
- ✅ File an issue
- ❌ Addition/Change/Update/Fix
- ❌ Testing to ensure no regression
- ➖ Automated unit/functional testing coverage
- ➖ Developer Documentation support
- ➖ User Guide Documentation support
- ➖ UX/UI designer responsibilities
- ❌ Accessibility and Readability
- ❌ Reviewed by a human
- ❌ Code review by maintainers
- ❌ Full testing and approval
- ❌ Credit contributors
- ❌ Review with the product owner
- ❌ Update Release Notes
- ❌ Release
User interface changes
- The footer menu loses a duplicate entry and stops offering links that 404.
API changes
- N/A
Data model changes
- N/A
Release notes snippet
- Fixed the footer menu: removed the duplicated Privacy policy link and the link to a Terms and Conditions page that did not exist.
Issue fork rightup-3620714
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments