Problem/Motivation

I have a few small suggestions for this great module, and instead of issues for each one, I'll group them here. Let me know if you prefer them split up.

When you first install Token Browser, you may click around and not understand if it is in use, or not.

Also, if someone installs this module, we can assume they want to use it, so I think we can be bold, and enable it on installation.

Since the user can now expand the window, we can improve the UI, by not allowing texts strings to break, which can make the UI look funny, with jumbled up text.

Steps to reproduce

Proposed resolution

  • Enable Token browser on installation.
  • Show token names on the same line via CSS.
  • Make it clearer that Token browser is used, with "Available tokens (Token browser)" in the window title.

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork token_browser-3620411

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

ressa created an issue. See original summary.

ressa opened merge request !5

ressa’s picture

ressa
he/him
commented
Status: Active » Needs review

I only have one failing test locally which seems unrelated, since I also get it with a fresh clone: Current response header "X-Drupal-Dynamic-Cache" is "", but "UNCACHEABLE (poor cacheability)"

Anyway, these changes may not even happen, so tests can always be fixed later :) I am looking forward to hearing your thoughts about these suggestions.

apmsooner’s picture

apmsooner commented
Status: Needs review » Needs work

The test failures on gitlab are due to the title changes in "Make it clearer that Token browser is used, with "Available tokens (Token browser)" in the window title."

I think we could probably do without that addition as normal users probably don't need to know or care about the provider of the dialog. The other 2 suggestions I'm good with and since I already merged the other ticket, rebase this one with just the 2 changes and I'd be happy to consider with passing tests.

ressa opened merge request !6

ressa’s picture

ressa
he/him
commented
Title: Enable by default and clarify that Drupal core Token browser is not used » Enable by default and show token names on one line
Issue summary: View changes
Status: Needs work » Needs review

Thank you for being open to these suggestions, I ended up making a fresh branch, with just "Enable Token browser on installation." and "Show token names on the same line via CSS."

apmsooner’s picture

apmsooner commented
Status: Needs review » Fixed

Looks good to me so merged! Thanks for the contribution.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

apmsooner’s picture

apmsooner commented
Status: Fixed » Closed (fixed)
ressa’s picture

ressa
he/him
commented

Thank you @apmsooner, it looks great!