Problem/Motivation

In a workspace, a view for a supported non-translatable entity type displays default revision values instead of the workspace-specific pending revision ones.

Steps to reproduce

Install Workspaces and the contrib Redirect module with issue #3313540: Convert the Redirect entity type to revisionable applied.

  1. In Live, create a redirect with the source path /old.
  2. Create a workspace and activate it.
  3. Edit that redirect and change its source path to /new.
  4. Visit /admin/config/search/redirect.

The listing still shows /old instead of the pending revision value.

Proposed resolution

The list of fields to read from the revision table currently requires a revision data table. Build it from the revisionable field storage definitions on the base table instead. Translatable entity types are not affected by this change.

Remaining tasks

Review.

User interface changes

Nope.

Introduced terminology

N/A

API changes

Nope.

Data model changes

Nope.

Release notes snippet

N/A

Issue fork drupal-3619974

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

amateescu created an issue. See original summary.

amateescu opened merge request !16919

amateescu’s picture

amateescu commented
Status: Active » Needs review
gabesullice’s picture

gabesullice
Primary language English
commented
Status: Needs review » Reviewed & tested by the community
plach’s picture

plach
he/him
Primary language Italian
Location Venezia
commented

RTBC +1, if we happen to touch this again we may address the nit above.

  • catch committed 4240fa27 on main 
    fix: #3619974 A view in a workspace shows default revision values for...
catch’s picture

catch
he/him
Primary language English
commented
Version: main » 11.x-dev
Status: Reviewed & tested by the community » Fixed

Agreed the variable name change is OK in a follow-up, the database API itself calls columns fields quite a lot so not really inconsistent with that anyway.

Committed/pushed to main and 11.x, thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

  • catch committed b1582542 on 11.x 
    fix: #3619974 A view in a workspace shows default revision values for...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.