Problem/Motivation

@berdir mentioned that it should not return string. Postponed on #3580703: Deprecate update.module functions

Changing the detail to null broke some unit tests.

We can explore fixing that here.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3619763

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

nicxvan created an issue. See original summary.

nicxvan’s picture

nicxvan commented
Status: Active » Postponed
danielveza’s picture

danielveza
he/him
Location Brisbane, AU
commented

What is this postponed on?

nicxvan’s picture

nicxvan commented
Issue summary: View changes
Related issues: +#3580703: Deprecate update.module functions

Whoops!

danielveza’s picture

danielveza
he/him
Location Brisbane, AU
commented
Title: [pp-1] Clean up UpdateMessageTrait::getText return type » Clean up UpdateMessageTrait::getText return type
Status: Postponed » Active

No longer postponed

danielveza opened merge request !17112

danielveza’s picture

danielveza
he/him
Location Brisbane, AU
commented

Opened an MR with the change, I'll circle back later to see what fails

danielveza’s picture

danielveza
he/him
Location Brisbane, AU
commented
Status: Active » Needs review

Tests are green, behaviour should be unchanged. I think this is ready for review.

nicxvan’s picture

nicxvan commented
Status: Needs review » Reviewed & tested by the community

Oh that's actually pretty straightforward.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Version: main » 11.x-dev
Status: Reviewed & tested by the community » Fixed

Committed and pushed a51813d2e6e to main and 510bd81c3f1 to 11.x. Thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

  • longwave committed 510bd81c on 11.x 
    refactor: #3619763 Clean up UpdateMessageTrait::getText return type

By...

  • longwave committed a51813d2 on main 
    refactor: #3619763 Clean up UpdateMessageTrait::getText return type

By...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.