Problem/Motivation

Every time we generate permissions for filter module, we generate links. This adds approximately 500ms to every Drupal standard install installation because it immediately rebuilds the router.

Steps to reproduce

Proposed resolution

Remove the links.

If there's a way to use Markup / stringable in the arguments to t() that might be another option - the problem isn't the links as such but generating them to build the markup object, which causes the lazy installer router to be rebuilt.

Haven't fully verified this yet but it's probably happening in tests too, so tagging

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3619751

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

catch created an issue. See original summary.

catch’s picture

catch
he/him
Primary language English
commented
Status: Active » Needs review

catch opened merge request !16894

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Seems straight forward enough.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Reviewed & tested by the community » Needs work

FilterDefaultConfigTest has this comment which needs updating now (and probably some support code can be removed from the test)

    // Drupal\filter\FilterPermissions::permissions() builds a URL to output
    // a link in the description.
catch’s picture

catch
he/him
Primary language English
commented
Status: Needs work » Reviewed & tested by the community

Good spot - we can remove that comment and the line immediately following it. Test still needs user module installed because it does things with roles.

  • longwave committed 12b38bda on main 
    task: #3619751 Remove links from filter permission descriptions

By:...
longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed 12b38bdacee to main. Thanks!

As this is primarily for test performance I didn't bother with a backport.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.