Problem/Motivation

Since the beginning of the project, some contributors are running php-cs-fixer with the module ruleset : https://git.drupalcode.org/project/display_builder/-/blob/1.0.x/.php-cs-...

But it is not enforced and some contributors are not.

So, when we run php-cs-fixer, we have sometimes changes not related to the current work.

Proposed resolution

Do we add php-cs-fixer to the pipeline?

UI Patterns is doing it: #3619588: Add PHP Coding Standards Fixer to the pipeline. Is it the opportunity to add a similar job?

Comments

pdureau created an issue. See original summary.

mogtofu33’s picture

mogtofu33 commented
Assigned: Unassigned » mogtofu33
Status: Active » Needs work
mogtofu33’s picture

mogtofu33 commented
Assigned: mogtofu33 » Unassigned
Status: Needs work » Fixed

Added, not that the job like on ui_patterns is in --dry-run mode, it just detect missing run and do not fix them directly. Which will be something to evaluate later.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

  • mogtofu33 committed 59e80b52 on 1.0.x 
    task: #3619629 Add PHP Coding Standards Fixer to the pipeline

By:...

  • mogtofu33 committed 056c98c7 on 1.0.x 
    task: #3619629 fix php-cs-fixer list of files

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.