Problem/Motivation

drupal-11.3.0.filled.standard.php.gz

Uninstalled

  • Search

Installed
> NA

Deleted
> All fields with text_with_summary plugin

================

drupal-11.3.0.bare.standard.php.gz

Uninstalled

  • Search
  • Shortcut
  • Toolbar
  • Olivero

Installed

  • Navigation

Deleted
> All fields with text_with_summary plugin

Steps to reproduce

NA

Proposed resolution

Update fixtures based on above

Remaining tasks

Review

User interface changes

NA

Introduced terminology

NA

API changes

NA

Data model changes

NA

Release notes snippet

NA

Issue fork drupal-3619365

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

smustgrave created an issue. See original summary.

smustgrave’s picture

Issue summary: View changes
smustgrave’s picture

Issue summary: View changes

smustgrave’s picture

Issue summary: View changes
smustgrave’s picture

Issue summary: View changes
smustgrave’s picture

Issue summary: View changes
smustgrave’s picture

Status: Active » Needs review
dcam’s picture

Status: Needs review » Reviewed & tested by the community

I diffed the new fixtures against the current ones. They look good to me. I don't think they need any additional changes, but I made a couple of notes.

  • The bare fixture uninstalled Olivero in addition to the changes listed in the IS.
  • The fixture removes a field on the "Test" content type, field_test_14, which is a text_with_summary field. It was removed without replacement. The content type appears to be a testing ground for all Core field types. So removing it entirely seems appropriate to me.

Otherwise the changes are related to the uninstalled modules and text_with_summary field deletions. I didn't see anything unusual.

It looks like Search is pretty close to being ready for removal. So I'd guess it's OK to remove the tests at this time.

catch’s picture

Issue summary: View changes
catch’s picture

Status: Reviewed & tested by the community » Fixed

Dropping the search tests is fine in main since the entire module will be removed soon, I don't think we can do that in 11.x but maybe we should leave the dump as it is in 11.3 for now?

Moving to to be ported to discuss.

Committed/pushed to main, thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

  • catch committed 9b325116 on main
    task: #3619365 Update 11.3 fixtures to remove deprecated modules
    
    By:...
catch’s picture

Status: Fixed » Patch (to be ported)
smustgrave’s picture

Would think we can’t do on 11.x as search will have to remain and we definitely want to keep those tests there

godotislate’s picture

Having different 11.3 fixtures between 11.x and main could make creating update test fixtures such as for #2865710: Dependencies from only one instance of a widget are used in display modes very difficult.

smustgrave’s picture

Assigned: smustgrave » Unassigned

Not entirely sure how to add to 11.x though..

catch’s picture

Status: Patch (to be ported) » Fixed

Yeah let's leave this fixed on main. If something comes up we can deal with it then.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.