Problem/Motivation

Thanks this looks and works really well! In itself, being able to click the words, and not having to click on the icon is a great improvement.

I was reminded about a Token browser issue, where the Token browser size is part of the discussion, in #3489325: Inline access via each field to Token browser.

I always have to resize the window, and wonder if a "Token browser size" option could be added under Token Browser settings? Personally, I would crank it up to 1200 x 700 straight away, if it was possible.

Token browser size
Set the size of the pop-up window.
[ ] 600 x 400 pixels
[ ] 800 x 500 pixels
[ ] 1000 x 600 pixels
[x] 1200 x 700 pixels

Token browser size example

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#2 token-browser-size-example-v2.png60.14 KBressa
token-browser-size-example.png61.17 KBressa

Issue fork token_browser-3619242

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

ressa created an issue. See original summary.

ressa’s picture

ressa
he/him
commented
Issue summary: View changes
StatusFileSize
new token-browser-size-example-v2.png60.14 KB
apmsooner’s picture

apmsooner commented

Hey there, I meant to respond to this earlier and simply forgot so sorry about the delay! I think the request is reasonable and I will research a path forward to make it happen as soon as I get a chance. I'll post an update to this soon.

Thanks

ressa’s picture

ressa
he/him
commented

Hi @apmsooner, no problem, I think that was a pretty fast answer actually :)

It sounds fantastic that this may be possible at some point, thank you so much. Maybe the default could be 800 x 500, or even 1000 x 600 pixels, to really drive this killer feature home? Those who like the small window in the bottom right corner can always dial it down.

apmsooner opened merge request !4

apmsooner’s picture

apmsooner commented
Status: Active » Needs review

This is ready to review. I set the default size at 800 x 500. The width/height fields are separate vs. a dropdown for configuration semantics and to provide more flexibility but they do have reasonable min/max limits. Let me know if its good for you and I'll merge as it was a pretty simple feature to add.

ressa’s picture

ressa
he/him
commented
Status: Needs review » Reviewed & tested by the community

This looks awesome, thanks! And good call to use input fields for the values, rather than drop-down, I agree -- that's more flexible.

apmsooner’s picture

apmsooner commented
Status: Reviewed & tested by the community » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

apmsooner’s picture

apmsooner commented
Status: Fixed » Closed (fixed)