Kessai renames part of its public API in #3618948: Name things the way Drupal core does: canceled over cancelled, module-prefixed *Hooks classes, cron() over onCron(), isHoldKept() over holdKept(), to match the way Drupal core names things. Eight lines in Yoyaku say the old names and have to move with it. Nothing is wrong with them today; this issue exists so the two land together.
plugin.manager.kessai_payment_gateway, following core's plugin.manager. convention: yoyaku_payment.services.yml line 27.PaymentManagerInterface::forgetCard() becomes deleteStoredCard(): yoyaku_payment/src/Hook/BookingPaymentHooks.php line 83, and yoyaku_orchestra_payment/src/Plugin/Action/DeleteCardAction.php line 42.claims() and refunds() gain core's get prefix: yoyaku_orchestra_payment/tests/src/Kernel/GuaranteeReturnTest.php lines 145, 207 and 276.PaymentEvents::CANCELLED and PaymentInterface::STATE_CANCELLED take core's American spelling, CANCELED and STATE_CANCELED: yoyaku_payment/src/EventSubscriber/OrderLockSubscriber.php line 75, and GuaranteeReturnTest.php line 166.Two of the eight break the site rather than a test if they land out of order. The service id is resolved from the container by name, so a Yoyaku that still asks for @kessai.gateway_manager against a renamed Kessai fails to compile the container, and every page goes down. The event constant is a compile-time class reference with the same effect. So this must merge together with #3618948: Name things the way Drupal core does: canceled over cancelled, module-prefixed *Hooks classes, cron() over onCron(), isHoldKept() over holdKept(), not after it.
The remaining six are method and constant references that fail loudly at the first call, and three of those are in one kernel test. Kessai is pre-1.0 and reinstall-only, so no stored value needs migrating: nothing in Yoyaku reads the raw 'cancelled' string or the raw event name, only the constants.
AI-Generated: Yes (Claude Code was used to help draft this issue summary and to find the affected lines. I reviewed it before posting; there is no code on this issue yet.)
Show commandsStart within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes, plain diff MR !307
Comments
Comment #3
mably commentedFolded in #3618938: Name things the way Drupal core does: the Trait and Hooks suffixes, core's verbs, American spelling and snake_case variables.