Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

Review help pages

  • admin/help/topic/contextual.overview
  • admin/help/topic/core.ui_components
  • admin/help/toolbar

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3618909

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

quietone created an issue. See original summary.

quietone opened merge request !16837

quietone’s picture

quietone commented
Issue summary: View changes
Status: Active » Needs review

I didn't make screenshots even thought this is changes the user interface. For me, I think it is better to browse the help to read this.

quietone’s picture

quietone commented
Title: Remove toolbar for help text not in the module » Remove toolbar help text not in the module
dcam’s picture

dcam commented
Status: Needs review » Needs work

There are a couple of mentions of the Toolbar in the announcements_feed help:

  • core/modules/announcements_feed/help_topics/announcements_feed.overview.html.twig
  • Drupal\announcements_feed\Hook\AnnouncementsFeedHelpHooks::help()

I'm setting the status to Needs Work for these to be checked.

From the work that's been done so far it appears that we aren't replacing any information on Toolbar with Navigation. In particular I wondered about the changes to core/modules/help/help_topics/core.ui_components.html.twig. If it isn't in-scope, then that's fine, but it might be worth noting so no one else wonders.

quietone’s picture

quietone commented
Status: Needs work » Needs review

I thought I got all those in announcements fixed? Anyway, did them again.

I do this it would be better to make a new issue, filed in Navigation, for any specifics improvements to the help text for the functionality it provides.

quietone’s picture

quietone commented

Something is wrong commit-code-check.sh for me locally. This is not the first time that spell checking did not find errors.

dcam’s picture

dcam commented
Status: Needs review » Needs work

I feel like this grammar needs some tweaking.

quietone’s picture

quietone commented
Status: Needs work » Needs review

I really should not work so late!

I applied the suggestion, which I agree is better. Since linting has passed I am setting back for review.

dcam’s picture

dcam commented
Status: Needs review » Reviewed & tested by the community

I really should not work so late!

I'm right there with you on that. Many of my mistakes can be traced back to being written between 11PM and midnight.

This looks good to me now.

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Needs work

Left some comments on the MR.

quietone’s picture

quietone commented
Status: Needs work » Needs review

Thanks, more instances removed.

catch’s picture

catch
he/him
Primary language English
commented
Status: Needs review » Reviewed & tested by the community

That looks better!

catch’s picture

catch
he/him
Primary language English
commented
Version: main » 11.x-dev
Status: Reviewed & tested by the community » Fixed

These were only small changes since the original RTBC, so going ahead here.

Committed/pushed to main and 11.x, thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

  • catch committed 3a4cfe46 on 11.x 
    task: #3618909 Remove toolbar help text not in the module

By: quietone...

  • catch committed 4c585253 on main 
    task: #3618909 Remove toolbar help text not in the module

By: quietone...
catch’s picture

catch
he/him
Primary language English
commented
Version: main » 11.x-dev
Status: Reviewed & tested by the community » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.