Problem/Motivation

Followup of #3615455: Install database driver modules alongside other modules. Every database driver is provided by a module. The helper method _install_get_database_module_name() is no longer needed and can be removed.

Steps to reproduce

Proposed resolution

Remove _install_get_database_module_name()

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3618797

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

daffie created an issue. See original summary.

daffie’s picture

daffie commented
Status: Postponed » Needs work

#3615455: Install database driver modules alongside other modules has landed.

daffie opened merge request !16854

daffie’s picture

daffie commented
Title: Replace _install_get_database_module() by Database::getConnection()->getProvider() » Replace _install_get_database_module_name() by Database::getConnection()->getProvider()
Issue summary: View changes

Updated the issue title and summary

daffie’s picture

daffie commented
Status: Needs work » Needs review

Ready for a review.

catch’s picture

catch
he/him
Primary language English
commented

One question on the MR but otherwise looks great.

catch’s picture

catch
he/him
Primary language English
commented

The original issue that prompted this introduced a test failure on mysqli (currently working on that there).

This brings up whether we should be explicitly finding and installing dependencies of database driver modules though, and where exactly that should happen.

catch’s picture

catch
he/him
Primary language English
commented

This was what I was wondering about on the other issue - didn't make it into the final commit: https://git.drupalcode.org/project/drupal/-/merge_requests/17006/diffs?c...

smustgrave’s picture

smustgrave commented

Do we need to deprecate this?

dcam’s picture

dcam commented

Do we need to deprecate this?

This function is considered internal for two reasons:

  • It is an underscore-prefixed function.
  • It is part of the installer.

There's always that "For internal APIs, a backwards compatible layer is provided when possible" clause of the BC policy, but this is one function people really shouldn't be calling.

Also, the contrib code search turned up zero results outside of install.core.inc.

dcam’s picture

dcam commented
Status: Needs review » Needs work

I updated the fork's branch because I was seeing different things between the contrib code search, the GitLab changes view, and the code in my local environment. For some reason a fresh pull did not include the two @see annotations that I've marked in the MR. They both reference the deleted function. They need to either be updated or removed.