Problem/Motivation

The first issue missed a toolbar_alter in the Announcements module

Steps to reproduce

Proposed resolution

Move any toolbar_alter hooks to the toolbar module

Remaining tasks

Review
Commit

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3618772

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

quietone created an issue. See original summary.

quietone opened merge request !16824

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Active » Needs work
Issue tags: +11.5.0 release priority

Yay!

https://api.drupal.org/api/drupal/core%21modules%21announcements_feed%21... and https://api.drupal.org/api/drupal/core%21modules%21announcements_feed%21... and https://api.drupal.org/api/drupal/11.x/search/announcements_feed.toolbar... that are all belong with this.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Title: Move toolbar hook implementations to the toolbar module, part 2 » Move toolbar_alter hook implementations to the toolbar module
quietone’s picture

quietone commented
Issue summary: View changes
Status: Needs work » Needs review

I disagree with changing the scope here. Comment #3 links to lazybuilders, libraries and CSS files in the announcement module but there are other instances in core. They should be scoped into other issues and this remains solely for the hook implementation.

Sorry for any confusion, I was working late and didn't complete the issue summary.

dcam’s picture

dcam commented
Status: Needs review » Needs work

I left suggestions related to @nicxvan's comment on the MR.

dcam’s picture

dcam commented
Status: Needs review » Reviewed & tested by the community

Looks good to me.

  • catch committed 92369c57 on 11.x 
    task: #3618772 Move toolbar_alter hook implementations to the toolbar...
catch’s picture

catch
he/him
Primary language English
commented
Version: main » 11.x-dev
Status: Reviewed & tested by the community » Fixed

Committed/pushed to main and 11.x, thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

  • catch committed d6ae4630 on main 
    task: #3618772 Move toolbar_alter hook implementations to the toolbar...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.