Problem/Motivation

The locale_translation_context module's drush.services.yml was out of sync with its constructor. It was passing 2 arguments, but the class now requires 3.

Steps to reproduce

Use drush updb, drush config import and/or drush deploy

Proposed resolution

Added the missing @locale_translation_context.po_database_reader service argument and created a patch to persist through updates.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
locale_translation_context_drush_services_missing_arg.patch391 bytesmarioheber

Issue fork locale_translation_context-3618464

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

marioheber created an issue. See original summary.

dkmishra’s picture

dkmishra commented

I was able to reproduce this issue:

ArgumentCountError: Too few arguments to function Drupal\locale_translation_context\Commands\LocaleTranslationContextCommands::__construct(), 2 passed and exactly 3 expected in /var/www/html/xxxxxxxxxxx/web/modules/contrib/locale_translation_context/src/Commands/LocaleTranslationContextCommands.php on line 30 #0 [internal function]: Drupal\locale_translation_context\Commands\LocaleTranslationContextCommands->__construct()

Thanks for the report and patch. Tried applying it against the current 2.0.2 version and got a failure:

patching file drush.services.yml
Hunk #1 FAILED at 3.

Looks like the patch's context doesn't quite match the current version of drush.services.yml in HEAD, so it doesn't apply cleanly. Might be worth regenerating it against the latest copy of the file.

dkmishra opened merge request !7

dkmishra’s picture

dkmishra commented
Status: Active » Needs review

Opened MR !7, please review.

revagomes’s picture

revagomes commented
Status: Needs review » Reviewed & tested by the community

I confirm the patch is working

  • adelgado12 committed 4f438693 on 2.0.x 
    Issue #3618464 - Remove deprecated drush.services.yml file
adelgado12’s picture

adelgado12 commented
Status: Reviewed & tested by the community » Patch (to be ported)
adelgado12’s picture

adelgado12 commented
Status: Patch (to be ported) » Fixed

Fixed in 2.0.3

Thanks marioheber, dkmishra and revagomes

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.