Problem/Motivation

Fix this:

 ------ ---------------------------------------------------------------------- 
  Line   modules/gnode/src/Hook/EntityHooks.php                                
 ------ ---------------------------------------------------------------------- 
  55     Method Drupal\gnode\Hook\EntityHooks::entityOperation() implements    
         hook_entity_operation but is missing the CacheableMetadata parameter  
         added in Drupal 11.3. Update the signature to include                 
         \Drupal\Core\Cache\CacheableMetadata $cacheability as the second      
         parameter.                                                            
         🪪  drupal.hookEntityOperationMissingCacheabilityParameter            
         💡  See https://www.drupal.org/node/3533080                           
 ------ ---------------------------------------------------------------------- 
 ------ ----------------------------------------------------------------------- 
  Line   src/Entity/Controller/GroupListBuilder.php                             
 ------ ----------------------------------------------------------------------- 
  26     Direct injection of entity storage via $storage is not recommended.    
         Inject Drupal\Core\Entity\EntityTypeManagerInterface and call          
         getStorage() at the call-site instead.                                 
         🪪  drupal.entityStorageDirectInjection                                
         💡  See                                                                
         https://mglaman.dev/blog/dependency-injection-anti-patterns-drupal     
  128    Method                                                                 
         Drupal\group\Entity\Controller\GroupListBuilder::getDefaultOperations  
         () is missing the CacheableMetadata parameter added in Drupal 11.3.    
         Update the signature to:                                               
         getDefaultOperations(\Drupal\Core\Entity\EntityInterface $entity,      
         ?\Drupal\Core\Cache\CacheableMetadata $cacheability = NULL).           
         🪪  drupal.entityListBuilderMissingCacheabilityParameter               
         💡  See https://www.drupal.org/node/3533080                            
 ------ ----------------------------------------------------------------------- 
 ------ ----------------------------------------------------------------------- 
  Line   src/Entity/Controller/GroupRelationshipListBuilder.php                 
 ------ ----------------------------------------------------------------------- 
  112    Method                                                                 
         Drupal\group\Entity\Controller\GroupRelationshipListBuilder::getDefau  
         ltOperations() is missing the CacheableMetadata parameter added in     
         Drupal 11.3. Update the signature to:                                  
         getDefaultOperations(\Drupal\Core\Entity\EntityInterface $entity,      
         ?\Drupal\Core\Cache\CacheableMetadata $cacheability = NULL).           
         🪪  drupal.entityListBuilderMissingCacheabilityParameter               
         💡  See https://www.drupal.org/node/3533080                            
 ------ ----------------------------------------------------------------------- 
 ------ ----------------------------------------------------------------------- 
  Line   src/Entity/Controller/GroupRoleListBuilder.php                         
 ------ ----------------------------------------------------------------------- 
  30     Direct injection of entity storage via $storage is not recommended.    
         Inject Drupal\Core\Entity\EntityTypeManagerInterface and call          
         getStorage() at the call-site instead.                                 
         🪪  drupal.entityStorageDirectInjection                                
         💡  See                                                                
         https://mglaman.dev/blog/dependency-injection-anti-patterns-drupal     
  114    Method                                                                 
         Drupal\group\Entity\Controller\GroupRoleListBuilder::getDefaultOperat  
         ions() is missing the CacheableMetadata parameter added in Drupal      
         11.3. Update the signature to:                                         
         getDefaultOperations(\Drupal\Core\Entity\EntityInterface $entity,      
         ?\Drupal\Core\Cache\CacheableMetadata $cacheability = NULL).           
         🪪  drupal.entityListBuilderMissingCacheabilityParameter               
         💡  See https://www.drupal.org/node/3533080                            
 ------ ----------------------------------------------------------------------- 
 ------ ----------------------------------------------------------------------- 
  Line   src/Entity/Controller/GroupTypeListBuilder.php                         
 ------ ----------------------------------------------------------------------- 
  45     Method                                                                 
         Drupal\group\Entity\Controller\GroupTypeListBuilder::getDefaultOperat  
         ions() is missing the CacheableMetadata parameter added in Drupal      
         11.3. Update the signature to:                                         
         getDefaultOperations(\Drupal\Core\Entity\EntityInterface $entity,      
         ?\Drupal\Core\Cache\CacheableMetadata $cacheability = NULL).           
         🪪  drupal.entityListBuilderMissingCacheabilityParameter               
         💡  See https://www.drupal.org/node/3533080                            
 ------ ----------------------------------------------------------------------- 
 ------ ----------------------------------------------------------------------- 
  Line   src/Plugin/Condition/GroupType.php                                     
 ------ ----------------------------------------------------------------------- 
  30     Direct injection of entity storage via $entityStorage is not           
         recommended. Inject Drupal\Core\Entity\EntityTypeManagerInterface and  
         call getStorage() at the call-site instead.                            
         🪪  drupal.entityStorageDirectInjection                                
         💡  See                                                                
         https://mglaman.dev/blog/dependency-injection-anti-patterns-drupal     
 ------ ----------------------------------------------------------------------- 
 ------ --------------------------------------------------------------------- 
  Line   src/Plugin/Group/Relation/GroupRelationTypeManager.php               
 ------ --------------------------------------------------------------------- 
  218    Storing entity storage as a class property is not recommended. Call  
         Drupal\Core\Entity\EntityTypeManagerInterface::getStorage() at the   
         call-site instead.                                                   
         🪪  drupal.entityStoragePropertyAssignment                           
         💡  See                                                              
         https://mglaman.dev/blog/dependency-injection-anti-patterns-drupal   
  231    Storing entity storage as a class property is not recommended. Call  
         Drupal\Core\Entity\EntityTypeManagerInterface::getStorage() at the   
         call-site instead.                                                   
         🪪  drupal.entityStoragePropertyAssignment                           
         💡  See                                                              
         https://mglaman.dev/blog/dependency-injection-anti-patterns-drupal   
 ------ --------------------------------------------------------------------- 
 ------ ----------------------------------------------------------------------- 
  Line   src/Plugin/Menu/LocalAction/WithDestination.php                        
 ------ ----------------------------------------------------------------------- 
  26     Drupal\Core\DependencyInjection\DependencySerializationTrait does not  
         support private properties.                                            
         🪪  dependencySerializationTraitProperty.unsupportedPrivateProperty    
         💡  See https://www.drupal.org/node/3110266                            
 ------ ----------------------------------------------------------------------- 
 ------ ----------------------------------------------------------------------- 
  Line   src/Plugin/views/argument/GroupId.php                                  
 ------ ----------------------------------------------------------------------- 
  20     Direct injection of entity storage via $groupStorage is not            
         recommended. Inject Drupal\Core\Entity\EntityTypeManagerInterface and  
         call getStorage() at the call-site instead.                            
         🪪  drupal.entityStorageDirectInjection                                
         💡  See                                                                
         https://mglaman.dev/blog/dependency-injection-anti-patterns-drupal     
 ------ ----------------------------------------------------------------------- 
 ------ --------------------------------------------------------------------- 
  Line   tests/src/Functional/GroupRoleFormTest.php                           
 ------ --------------------------------------------------------------------- 
  38     Storing entity storage as a class property is not recommended. Call  
         Drupal\Core\Entity\EntityTypeManagerInterface::getStorage() at the   
         call-site instead.                                                   
         🪪  drupal.entityStoragePropertyAssignment                           
         💡  See                                                              
         https://mglaman.dev/blog/dependency-injection-anti-patterns-drupal   
 ------ --------------------------------------------------------------------- 
 ------ --------------------------------------------------------------------- 
  Line   tests/src/Kernel/ConfigEntityAccessTest.php                          
 ------ --------------------------------------------------------------------- 
  75     Storing entity storage as a class property is not recommended. Call  
         Drupal\Core\Entity\EntityTypeManagerInterface::getStorage() at the   
         call-site instead.                                                   
         🪪  drupal.entityStoragePropertyAssignment                           
         💡  See                                                              
         https://mglaman.dev/blog/dependency-injection-anti-patterns-drupal   
 ------ --------------------------------------------------------------------- 
 ------ --------------------------------------------------------------------- 
  Line   tests/src/Kernel/ConfigWrapperStorageTest.php                        
 ------ --------------------------------------------------------------------- 
  41     Storing entity storage as a class property is not recommended. Call  
         Drupal\Core\Entity\EntityTypeManagerInterface::getStorage() at the   
         call-site instead.                                                   
         🪪  drupal.entityStoragePropertyAssignment                           
         💡  See                                                              
         https://mglaman.dev/blog/dependency-injection-anti-patterns-drupal   
 ------ --------------------------------------------------------------------- 
 ------ --------------------------------------------------------------------- 
  Line   tests/src/Kernel/ConfigWrapperTest.php                               
 ------ --------------------------------------------------------------------- 
  39     Storing entity storage as a class property is not recommended. Call  
         Drupal\Core\Entity\EntityTypeManagerInterface::getStorage() at the   
         call-site instead.                                                   
         🪪  drupal.entityStoragePropertyAssignment                           
         💡  See                                                              
         https://mglaman.dev/blog/dependency-injection-anti-patterns-drupal   
 ------ --------------------------------------------------------------------- 
 ------ --------------------------------------------------------------------- 
  Line   tests/src/Kernel/ContentEntityAccessComplexTest.php                  
 ------ --------------------------------------------------------------------- 
  82     Storing entity storage as a class property is not recommended. Call  
         Drupal\Core\Entity\EntityTypeManagerInterface::getStorage() at the   
         call-site instead.                                                   
         🪪  drupal.entityStoragePropertyAssignment                           
         💡  See                                                              
         https://mglaman.dev/blog/dependency-injection-anti-patterns-drupal   
 ------ --------------------------------------------------------------------- 
 ------ --------------------------------------------------------------------- 
  Line   tests/src/Kernel/ContentEntityAccessTest.php                         
 ------ --------------------------------------------------------------------- 
  62     Storing entity storage as a class property is not recommended. Call  
         Drupal\Core\Entity\EntityTypeManagerInterface::getStorage() at the   
         call-site instead.                                                   
         🪪  drupal.entityStoragePropertyAssignment                           
         💡  See                                                              
         https://mglaman.dev/blog/dependency-injection-anti-patterns-drupal   
 ------ --------------------------------------------------------------------- 
 ------ --------------------------------------------------------------------- 
  Line   tests/src/Kernel/GroupRelationshipCardinalityTest.php                
 ------ --------------------------------------------------------------------- 
  64     Storing entity storage as a class property is not recommended. Call  
         Drupal\Core\Entity\EntityTypeManagerInterface::getStorage() at the   
         call-site instead.                                                   
         🪪  drupal.entityStoragePropertyAssignment                           
         💡  See                                                              
         https://mglaman.dev/blog/dependency-injection-anti-patterns-drupal   
  65     Storing entity storage as a class property is not recommended. Call  
         Drupal\Core\Entity\EntityTypeManagerInterface::getStorage() at the   
         call-site instead.                                                   
         🪪  drupal.entityStoragePropertyAssignment                           
         💡  See                                                              
         https://mglaman.dev/blog/dependency-injection-anti-patterns-drupal   
 ------ --------------------------------------------------------------------- 
 ------ --------------------------------------------------------------------- 
  Line   tests/src/Kernel/GroupRelationshipStorageTest.php                    
 ------ --------------------------------------------------------------------- 
  48     Storing entity storage as a class property is not recommended. Call  
         Drupal\Core\Entity\EntityTypeManagerInterface::getStorage() at the   
         call-site instead.                                                   
         🪪  drupal.entityStoragePropertyAssignment                           
         💡  See                                                              
         https://mglaman.dev/blog/dependency-injection-anti-patterns-drupal   
 ------ --------------------------------------------------------------------- 
 ------ --------------------------------------------------------------------- 
  Line   tests/src/Kernel/QueryAlter/EntityQueryAlterCacheabilityTest.php     
 ------ --------------------------------------------------------------------- 
  52     Storing entity storage as a class property is not recommended. Call  
         Drupal\Core\Entity\EntityTypeManagerInterface::getStorage() at the   
         call-site instead.                                                   
         🪪  drupal.entityStoragePropertyAssignment                           
         💡  See                                                              
         https://mglaman.dev/blog/dependency-injection-anti-patterns-drupal   
 ------ --------------------------------------------------------------------- 
 ------ --------------------------------------------------------------------- 
  Line   tests/src/Kernel/QueryAlter/QueryAlterTangibleTest.php               
 ------ --------------------------------------------------------------------- 
  65     Storing entity storage as a class property is not recommended. Call  
         Drupal\Core\Entity\EntityTypeManagerInterface::getStorage() at the   
         call-site instead.                                                   
         🪪  drupal.entityStoragePropertyAssignment                           
         💡  See                                                              
         https://mglaman.dev/blog/dependency-injection-anti-patterns-drupal   
 ------ ---------------------------------------------------------------------

Issue fork group-3618460

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

kristiaanvandeneynde created an issue. See original summary.

kristiaanvandeneynde opened merge request !324

kristiaanvandeneynde’s picture

kristiaanvandeneynde
Primary language Dutch
Location Antwerp, Belgium
commented
Status: Active » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.