Problem

Tests of custom-elements started failing today, since canvas 1.x introduced a change that breaks canvas-extjs HEAD:

ArgumentCountError: Too few arguments to JsonSchemaPropsComponentSourceBase::__construct(),
8 passed in canvas_extjs/.../ExternalJavaScriptComponent.php on line 87 and exactly 9 expected

It introduced a new argument to JsonSchemaPropsComponentSourceBase, so we need to follow that.

Related canvas issue: #3591838: Cron has no unconditional segment-coverage pass; lifecycle events accumulate indefinitely — "Brand Kit color support" (GitLab: https://git.drupalcode.org/project/canvas/-/work_items/3591838).

Steps to reproduce

check out dev versions and try it

Proposed resolution

follow changes, if possible backwards compatible, if not we bump the required version next release.

Issue fork canvas_extjs-3618329

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

fago created an issue. See original summary.

fago opened merge request !41

fago’s picture

fago
Primary language German
Location Vienna
commented
Status: Active » Needs review
fago’s picture

fago
Primary language German
Location Vienna
commented
Status: Needs review » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

  • fago committed 0e54f123 on 1.x 
    fix: #3618329 Latest canvas dev version is not compatible any more

By:...

  • fago committed 0e54f123 on 3618329-latest-canvas-dev-2 
    fix: #3618329 Latest canvas dev version is not compatible any more

By:...
fago’s picture

fago
Primary language German
Location Vienna
commented
Status: Needs review » Fixed

forgot about BC. While it's possible as https://git.drupalcode.org/project/canvas_extjs/-/jobs/11676205 shows, it's a bit troublesome. Let's do another minor with support with the next canvas version when it comes out instead.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.