Problem/Motivation

While working on #3617547: Make pattern presets buildable, we noticed some changes which can be done to fix stuff or clean stuff.

Proposed resolution

  • Remove InstanceInterface::isPublishable(), it looks like a leftover from the early days, useless now, and rely on the context_requirement mechanism which will be removed in UI Patterns.
  • Fix a context related bug introduced by #3549567: TokenSource::getContextDefinitions() always return entity in PatternPreset::getContextsFromSlots()
  • Rename PatternPresetInterface::getContexts() by ::getContextDefinitions(). It is not only an esthetic renaming, it also unlock the ability to have a proper getContexts() method later.
  • Remove the sources textarea in PatternPresetForm: it will be replaced by #3617547: Make pattern presets buildable. Even, if we postpone this ticket, the UX is too confusing and error prone.

Issue fork display_builder-3618100

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

pdureau created an issue. See original summary.

pdureau opened merge request !349

pdureau’s picture

pdureau commented
Assigned: pdureau » mogtofu33
Status: Active » Needs review

green pipeline

pdureau’s picture

pdureau commented
Assigned: mogtofu33 » pdureau
Status: Needs review » Needs work

oops, a little something to change

pdureau’s picture

pdureau commented
Assigned: pdureau » mogtofu33
Status: Needs work » Needs review

green pipeline

mogtofu33’s picture

mogtofu33 commented
Assigned: mogtofu33 » Unassigned
Status: Needs review » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.